-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dask expr cast
#821
feat: dask expr cast
#821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! Thanks for the effort! ππΌ
I left a few nitpicks here and there π
Regarding the failing test due to missing coverage, branches can't be all reach in the same test run π₯²
Co-authored-by: Francesco Bruzzesi <[email protected]>
for more information, see https://pre-commit.ci
Thanks for the review! :) Some CI failures:
|
I will take a look and see if I can spot anything
That's typically good news even though... why is that happening now π? Edit: Feel free to remove such block and check against CI. Locally I was able to get all green dots, but I can't replicate on windows. |
Co-authored-by: Francesco Bruzzesi <[email protected]>
Yeah, nevermind that, I figure CI coverage reports are a bit more involved than I understand rn. Gotta dig into it first. |
Hey there! I think the problem with coverage for python 3.8 is that dask is entirely skipped (min python version is 3.9), therefore as we increase total number of functions, the coverage will gradually decrease. I think you just unluckily hit the threshold number to push the total below 90%. As all other workflows are passing, I would not worry too much about it. I think we will need to be smarter about it or come with another threshold value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We adjusted the threshold to 85%, now some other unrelated CI error appeared π
uv pip install --pre --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple pandas --system
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.12.5/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.12.5/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.5/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.5/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.12.5/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.12.5/x64/lib
error: HTTP status server error (503 Service Unavailable) for url (https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/pandas/)
Error: Process completed with exit code 2.
Thanks @FBruzzesi ! |
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
Implemented without preserving a dtype backend for now. Need to dig more into that :P