-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DaskExpr.quantile
#835
Conversation
Hey @anopsy thanks for the PR 🙌🏼 My 2 cents: I would edit - if "dask" in str(constructor):
+ if "dask" in str(constructor) and interpolation != "nearest":
request.applymarker(pytest.mark.xfail) |
I hope you enjoy your holiday 😃 Thank you so much I knew I'm missing some really simple solution 🫶 |
I think it is only missing an disclaimer/note in the exposed method and then it should be good to go?! |
like that? |
Yes, you could add it in the already existing note and create bullet points. If possible please consider adding an embedded link to the dask method as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FBruzzesi cool, thanks for suggestion, was wondering how to arrange those two notes, also what do you mean by an embedded link to the dask method? A link to the dask docs? |
We end up using Series.quantile |
Edit: Thanks for help @FBruzzesi
Hello, that's my attempt at solving Dask
Expr.quantile
- the method works as expected (according to my own tests).However I've been trying to find a way to include dask-case in our tests, since dask can work only with interpolation="nearest" and not the other ones.What I tried:
if "dask" in str(contructor)
to call that test but also failed hereI was thinking about including every single constructor type in the parameters, but that seems a bit too verbose and the number of possible combinations is humongous.
At the moment I'm exploring other options, but feel free to 🛟 send help 🛟 if you know how to approach it
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.