Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL-66: Run npm audit fix #132

Merged
merged 1 commit into from
Aug 27, 2024
Merged

GQL-66: Run npm audit fix #132

merged 1 commit into from
Aug 27, 2024

Conversation

eudoroolivares2016
Copy link
Contributor

@eudoroolivares2016 eudoroolivares2016 commented Aug 26, 2024

Overview

What is the feature?

Snyk vul issue

What is the Solution?

Update dependencies with npm audit fix

What areas of the application does this impact?

Axios request updates minor version bumps on other libraries. Fairly large npm audit bump on this package-lock

Testing

Reproduction steps

  • **Environment for testing:SIT
  • **Collection to test with:Any
  1. Ensure that the reported snyk vul is no longer being reported in the build
  2. Regression test GQL functionality to ensure that functionality has not changed

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • [N/A] I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • [N/A] I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4b76957) to head (a6aa8e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2343      2343           
  Branches       262       262           
=========================================
  Hits          2343      2343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eudoroolivares2016 eudoroolivares2016 marked this pull request as ready for review August 26, 2024 18:47
@eudoroolivares2016 eudoroolivares2016 merged commit 9a73043 into main Aug 27, 2024
6 checks passed
@eudoroolivares2016 eudoroolivares2016 deleted the GQL-66 branch August 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants