Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQL-88: Updates CloudCover type #143

Merged
merged 1 commit into from
Nov 12, 2024
Merged

GQL-88: Updates CloudCover type #143

merged 1 commit into from
Nov 12, 2024

Conversation

macrouch
Copy link
Contributor

Overview

What is the feature?

The CloudCover field in the Granule type is currently an Int, but that value needs to be a Float

What is the Solution?

Updated the type in the schema.
CMR granule endpoints return different types. .json returns Strings while .umm_json returns a Float. I updated the tests to correctly reflect this

What areas of the application does this impact?

Granule queries with CloudCover

Testing

This query shows a PROD collection that does have floating point CloudCover values
Query

query Collection($params: CollectionInput) {
  collection(params: $params) {
    granules {
      count
      items {
        conceptId
        cloudCover
      }
    }
  }
}

Variables

{
  "params": {
    "conceptId": "C3020920290-OB_CLOUD"
  }
}

Checklist

  • I have added automated tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9bcdc0) to head (8724d5e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         2410      2410           
  Branches       273       273           
=========================================
  Hits          2410      2410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@macrouch macrouch merged commit 8f7da17 into main Nov 12, 2024
7 of 8 checks passed
@macrouch macrouch deleted the GQL-88 branch November 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants