GQL-10: Related URL tab is showing No value for provided message #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to now show up in MMT preview
dmistry1
requested review from
macrouch,
cgokey,
htranho,
tle1989 and
mandyparson
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 69
Lines 1544 1548 +4
Branches 209 210 +1
=========================================
+ Hits 1544 1548 +4 ☔ View full report in Codecov by Sentry. |
mandyparson
approved these changes
Dec 21, 2023
tle1989
approved these changes
Dec 21, 2023
|
Test coverage is still 100%, but I'd like to see a test specifically testing this new logic |
macrouch
approved these changes
Jan 10, 2024
cgokey
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed the bug that was causing the Related URL tab to have no values in MMT.