Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony 1495 - Reject request on submittal if EULA(s) not accepted #436

Merged
merged 17 commits into from
Jul 20, 2023

Conversation

vinnyinverso
Copy link
Collaborator

@vinnyinverso vinnyinverso commented Jul 19, 2023

Jira Issue ID

Harmony 1495

Description

Rejects request on submission and provides a link to the EULA to accept if the user has not accepted a EULA for a collection.
Currently the accept EULA EDL URLs are not working. There should be a fix in prod by some time next week.

Local Test Steps

Make a request with the following collections:

  twoEulasCollection = C1258836670-EEDTEST
  oneEulaCollection = C1258839703-EEDTEST
  badEulaIdCollection = C1258840703-EEDTEST

Depending on whether you've accepted the EULA for those collections, you'll either get a successful response or a 403 (in the case where you haven't accepted the EULA(s)) or a 404 (in the case where the metadata for the collection has a bad EULA ID).

If you want to see the 403 response, you may need to create a new test EDL user in UAT with no accepted EULAs. Please note that due to the EDL issue mentioned above, the 403 JSON response will return incorrect accept EULA URLs. The eula_id will be a query parameter, but in order to navigate to the right page, you'll need to remove that parameter and put the ID in the path instead, e.g.:
https://uat.urs.earthdata.nasa.gov/accept_eula?eula_id=be7c8c07-65f7-4e63-a81d-78dfa187870e => https://uat.urs.earthdata.nasa.gov/accept_eula/be7c8c07-65f7-4e63-a81d-78dfa187870e

Once you have accepted the EULA(s) returned by the error message, you should be able to execute the request successfully.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@vinnyinverso vinnyinverso marked this pull request as draft July 19, 2023 12:54
@vinnyinverso vinnyinverso marked this pull request as ready for review July 19, 2023 14:18
Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out successfully locally.

Copy link
Contributor

@indiejames indiejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@vinnyinverso vinnyinverso merged commit be6bed6 into main Jul 20, 2023
2 of 3 checks passed
@vinnyinverso vinnyinverso deleted the harmony-1495 branch July 20, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants