-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmony 1495 - Reject request on submittal if EULA(s) not accepted #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygliuvt
approved these changes
Jul 19, 2023
chris-durbin
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out successfully locally.
indiejames
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
Harmony 1495
Description
Rejects request on submission and provides a link to the EULA to accept if the user has not accepted a EULA for a collection.
Currently the accept EULA EDL URLs are not working. There should be a fix in prod by some time next week.
Local Test Steps
Make a request with the following collections:
Depending on whether you've accepted the EULA for those collections, you'll either get a successful response or a 403 (in the case where you haven't accepted the EULA(s)) or a 404 (in the case where the metadata for the collection has a bad EULA ID).
If you want to see the 403 response, you may need to create a new test EDL user in UAT with no accepted EULAs. Please note that due to the EDL issue mentioned above, the 403 JSON response will return incorrect accept EULA URLs. The eula_id will be a query parameter, but in order to navigate to the right page, you'll need to remove that parameter and put the ID in the path instead, e.g.:
https://uat.urs.earthdata.nasa.gov/accept_eula?eula_id=be7c8c07-65f7-4e63-a81d-78dfa187870e => https://uat.urs.earthdata.nasa.gov/accept_eula/be7c8c07-65f7-4e63-a81d-78dfa187870e
Once you have accepted the EULA(s) returned by the error message, you should be able to execute the request successfully.
PR Acceptance Checklist