HARMONY-2013: Check if a job is in a terminal state prior to attempting to process the STAC catalog for a work item update. #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to process the STAC catalog for a work item update.
ygliuvt
approved these changes
Feb 12, 2025
…d in the work update message.
indiejames
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-2013
Description
Fixes a bug we're seeing in UAT right now where a work item that takes more than 30 seconds to process is not getting cleaned up. This changes things to check the job status prior to doing any work for the work item and skips reading the STAC catalog and items if the job is already in a terminal state.
Local Test Steps
I reproduced the problem in my sandbox and then built and pushed the work-updater image. With the new image I verified it skipped reading the catalog and the SQS message was successfully deleted from the queue.
I've also verified with a 110K granule request that performance is not impacted by the extra DB call to get the job status.
PR Acceptance Checklist