Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the alloc_type of allocations performed by declare_var. #1529 #1639

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jmpenn
Copy link
Contributor

@jmpenn jmpenn commented Jan 23, 2024

This is a re-do of PR 1539 associated with 1529.

@jmpenn jmpenn marked this pull request as draft January 23, 2024 20:18
@coveralls
Copy link

Coverage Status

coverage: 55.903% (+0.01%) from 55.889%
when pulling 7266758 on Issue_1529v2
into 7547d36 on master.

@hchen99
Copy link
Contributor

hchen99 commented Jan 24, 2024

MM declare var sets alloc_type and the destructor gets called when delete_var, associated unit shows the intention. All looks good.

@jmpenn
Copy link
Contributor Author

jmpenn commented Jan 24, 2024

Also see Issue #1529 for additional comments.

@jmpenn jmpenn requested review from hchen99 and sharmeye January 24, 2024 16:49
@sharmeye sharmeye merged commit bfb6419 into master Jan 24, 2024
11 checks passed
@sharmeye sharmeye deleted the Issue_1529v2 branch January 24, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants