write template directive before template instance #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntaining class so that private methods are honored
excaliburtb
force-pushed
the
swig_template_fix
branch
from
1150766 to
1e0d781
Compare
|
@alexlin0 you wrote this in perl, this is your fault. Please read this and tell us what it says |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in newer swig versions. 4.2.1 confirmed.. maybe issue with any 4.x version, a template with a private copy constructor or operator will generate setters for the instance because swig doesn't know what the template is. swig documentation says to write the
%templatedirective first.This PR does that though I'm no expert on regex. feel free to rework as needed but this PR gets the job done for swig 4.2.1 and is backwards compatible with 3.0.12
See attachment to reproduce the error:
template_error.zip