fix: improve detection of poetry 2 projects #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects created with poetry >= 2.0 don't necessarily include a tool.poetry table in the pyproject.toml. Thus poethepoet cannot rely on the presence or absence of this table to tell whether it is appropriate to default to using the PoetryExecutor to run tasks with poetry's venv. It seems the best remaining indicator is the content of the build-system which poetry still configures consistently, although this is less ideal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects created with poetry >= 2.0 don't necessarily include a tool.poetry
table in the pyproject.toml. Thus poethepoet cannot rely on the presence or
absence of this table to tell whether it is appropriate to default to using
the PoetryExecutor to run tasks with poetry's venv.
It seems the best remaining indicator is the content of the build-system which
poetry still configures consistently, although this is less ideal.