Fix artnet pollreply #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: reads the mac address from the ethernet shield every time, could probably be set at Artnet construction since it is probably static.
According to the Art-Net spec, 0xc0 is for units both transmitting and recieving. 0x80 is for only recieving.
Set memory to 0 before writing the strings to 0 pad them.
The reply should only be sent to the requesting Controller, not multicast. From https://art-net.org.uk/structure/discovery-packets/ "Upon receipt of an ArtPoll, all Art-Net devices respond by unicasting an ArtPollReply." (this also solved the port-errors that i got, dont know if it was my network, but when sending the reply to broadcast the target port became "65")
The universe-addressing is 0-indexed.
|
This fixed Unicast for Resolume Arena here. |
rin1024
added a commit
to rin1024/Artnet
that referenced
this pull request
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't detect my Teensy in my lighting controller (Obsidian Onyx), so using the specification and DMX-Workshop from Artistic License i found some errors in ArtPollReply.
With these changes the Teensy gets detected and can receive universe data through unicast automatically.
(I haven't tried mac address with esp32 etc, but according to the wifi docs, this should work)