Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple NSSpeechSynthesizer (nsss) writes .aiff, not .wav files #376

Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 7, 2024

Fix our tests to deal with the .aiff vs. .wav issue discussed at #361 (comment)

Also fixes a crash bug in example/repeatvoice.py.

@cclauss cclauss force-pushed the fix-test_saving_to_file-on-macos branch from 54626c7 to 17e398c Compare November 7, 2024 11:38
@cclauss cclauss force-pushed the fix-test_saving_to_file-on-macos branch from 17e398c to ea06087 Compare November 7, 2024 12:09
Copy link
Collaborator

@willwade willwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me this!

@willwade willwade merged commit 302cdec into nateshmbhat:master Nov 7, 2024
12 checks passed
@cclauss cclauss deleted the fix-test_saving_to_file-on-macos branch November 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants