Skip to content

Commit

Permalink
python: Consistently add single element to list using append()
Browse files Browse the repository at this point in the history
For no other reason than style :)

Signed-off-by: Nathan Chancellor <[email protected]>
  • Loading branch information
nathanchance committed Dec 12, 2023
1 parent 92acceb commit 3ffd115
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion python/lib/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ def setup_sudo_symlink():
def systemctl_enable(items_to_enable, now=True):
cmd = ['systemctl', 'enable']
if now:
cmd += ['--now']
cmd.append('--now')
cmd += items_to_enable

subprocess.run(cmd, check=True)
Expand Down
2 changes: 1 addition & 1 deletion python/scripts/tuxmake_bld_all.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def get_env_make_variables(target_arch, toolchain):
def get_targets(kconfig):
targets = ['default']
if kconfig == 'defconfig':
targets += ['kernel']
targets.append('kernel')
return targets


Expand Down
4 changes: 2 additions & 2 deletions python/setup/arch.py
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,9 @@ def pacman_install_packages():
] # yapf: disable

if lib.setup.is_virtual_machine():
packages += ['devtools']
packages.append('devtools')
else:
packages += ['tailscale']
packages.append('tailscale')

# Update and install packages
pacman_install(['--needed', *packages])
Expand Down
6 changes: 3 additions & 3 deletions python/setup/fedora.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,14 +141,14 @@ def install_packages():

# Install Virtualization group on Equinix Metal servers or trusted machines
if lib.setup.is_equinix() or machine_is_trusted():
packages += ['@virtualization']
packages.append('@virtualization')

if machine_is_trusted():
packages += ['tailscale']
packages.append('tailscale')

# Needed to occasionally upgrade the MMC firmware
if lib.setup.get_hostname() == 'aadp':
packages += ['ipmitool']
packages.append('ipmitool')

dnf_install(packages)

Expand Down

0 comments on commit 3ffd115

Please sign in to comment.