Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Playlists looking good in Navidrome via compilation-tag #738

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion streamrip/media/playlist.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,15 @@ async def resolve(self) -> Track | None:
)
self.db.set_failed(self.client.source, "track", self.id)
return None


meta.compilation = 1
c = self.config.session.metadata
if c.renumber_playlist_tracks:
meta.tracknumber = self.position
if c.set_playlist_to_album:
album.album = self.playlist_name
album.albumartist = "Playlist"


quality = self.config.session.get_source(self.client.source).quality
try:
Expand Down
1 change: 1 addition & 0 deletions streamrip/metadata/tagger.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ def _attr_from_meta(self, meta: TrackMetadata, attr: str) -> str | None:
"tracknumber",
"discnumber",
"composer",
"compilation",
"isrc",
}
if attr in in_trackmetadata:
Expand Down
2 changes: 2 additions & 0 deletions streamrip/metadata/track.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class TrackMetadata:
tracknumber: int
discnumber: int
composer: str | None
compilation: int = 0
isrc: str | None = None

@classmethod
Expand Down Expand Up @@ -208,6 +209,7 @@ def from_tidal(cls, album: AlbumMetadata, track) -> TrackMetadata:
tracknumber=tracknumber,
discnumber=discnumber,
composer=None,
compilation=0,
isrc=isrc,
)

Expand Down