Work in progress, case sensitivity is going to be tricky #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-instance into automated-ledger-update
…ed-instance into automated-ledger-update
…ed-instance into automated-ledger-update
…ed-instance into automated-ledger-update
aahna-ashina
requested changes
Apr 9, 2023
Comment on lines
-7721
to
+7723
| {"action":{"currency":{"chainId":"1","tokenAddress":"0x333A4823466879eeF910A04D473505da62142069","type":"EVM"},"id":"BtlDOgLvfl76rb1jGwi1oQ","payoutAddress":"0x4e3072f7b5c075ea5fdeb423da95312c4b99dc22","type":"SET_PAYOUT_ADDRESS"},"ledgerTimestamp":1652508453019,"uuid":"2FArHEDBcgKBp44XNOpotQ","version":"1"} | ||
| {"action":{"currency":{"chainId":"1","tokenAddress":"0x333A4823466879eeF910A04D473505da62142069","type":"EVM"},"id":"LMUEWiZux2Q8iAcKKy8gGg","payoutAddress":"0x4e3072f7b5c075ea5fdeb423da95312c4b99dc22","type":"SET_PAYOUT_ADDRESS"},"ledgerTimestamp":1652508458077,"uuid":"Q1AmEyAVEg4P5cxyb8ejIA","version":"1"} | ||
| {"action":{"currency":{"chainId":"1","tokenAddress":"0x333A4823466879eeF910A04D473505da62142069","type":"EVM"},"id":"o4RCyNUm0AM3DF6NqrRLnQ","payoutAddress":"0x4e3072f7b5c075ea5fdeb423da95312c4b99dc22","type":"SET_PAYOUT_ADDRESS"},"ledgerTimestamp":1652508470072,"uuid":"8uRBXGtmSlM0WynJgnCkQw","version":"1"} | ||
| {"action":{"currency":{"chainId":"1","tokenAddress":"0x333A4823466879eeF910A04D473505da62142069","type":"EVM"},"id":"BtlDOgLvfl76rb1jGwi1oQ","payoutAddress":"0x4e3072f7b5C075EA5FdEb423DA95312C4B99dc22","type":"SET_PAYOUT_ADDRESS"},"ledgerTimestamp":1652508453019,"uuid":"2FArHEDBcgKBp44XNOpotQ","version":"1"} | ||
| {"action":{"currency":{"chainId":"1","tokenAddress":"0x333A4823466879eeF910A04D473505da62142069","type":"EVM"},"id":"LMUEWiZux2Q8iAcKKy8gGg","payoutAddress":"0x4e3072f7b5C075EA5FdEb423DA95312C4B99dc22","type":"SET_PAYOUT_ADDRESS"},"ledgerTimestamp":1652508458077,"uuid":"Q1AmEyAVEg4P5cxyb8ejIA","version":"1"} | ||
| {"action":{"currency":{"chainId":"1","tokenAddress":"0x333A4823466879eeF910A04D473505da62142069","type":"EVM"},"id":"o4RCyNUm0AM3DF6NqrRLnQ","payoutAddress":"0x4e3072f7b5C075EA5FdEb423DA95312C4B99dc22","type":"SET_PAYOUT_ADDRESS"},"ledgerTimestamp":1652508470072,"uuid":"8uRBXGtmSlM0WynJgnCkQw","version":"1"} |
There was a problem hiding this comment.
@johnmark13 The change from lower-case to checksummed is probably because you manually ran sourcecred load before running yarn update-ledger-from-chain? It makes it difficult to review the changes, so can we make a PR without these upper-case/lower-case diffs?
There was a problem hiding this comment.
I don't think so, we definitely cannot easilly split to multiple PRs. I wonder if SourceCred automatically converts the case to checksummed when setting the payout address, and we have them in lower case because of that script you ran before? If we let the ledger hold checksummed addresses it won't update them after the first time making PRs more simple.
|
|
||
| console.log(`Setting payout address for GitHub for passport ${passport_id} - gitHubUsername ${dUsername}`) | ||
|
|
||
| ledgerManager.ledger.setPayoutAddress(baseIdentityId, owner_address ,chainId, tokenAddress); |
There was a problem hiding this comment.
Suggested change
| ledgerManager.ledger.setPayoutAddress(baseIdentityId, owner_address ,chainId, tokenAddress); | |
| ledgerManager.ledger.setPayoutAddress(baseIdentityId, owner_address, chainId, tokenAddress); |
scripts/update-ledger-from-chain.js
Outdated
|
|
||
| const discourseFile = await readCsv(FILE_DISCOURSE_CSV); | ||
|
|
||
| console.info(`Read Citizen Disource data from Github`); |
There was a problem hiding this comment.
Suggested change
| console.info(`Read Citizen Disource data from Github`); | |
| console.info(`Read Citizen Discourse data from Github`); |
Co-authored-by: Aahna Ashina <[email protected]>
…ed-instance into automated-ledger-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP