FCL-477 | linting

ds_judgements_public_ui/sass/includes/_basic_search_form.scss

@@ -35,6 +35,7 @@
       display: inline-block;
 
       margin-bottom: $space-3;
+      border: 0;
 
       font-family: $font-roboto;
       font-size: $typography-md-text-size;
@@ -43,7 +44,6 @@
       text-decoration: underline;
 
       background: transparent;
-      border: 0;
 
       &:visited {
         color: colour-var("link");

ds_judgements_public_ui/sass/includes/_buttons.scss

@@ -3,24 +3,25 @@
 
   margin-top: $space-4;
   padding: $space-4 $space-5;
+  border: 0;
 
   font-size: $typography-md-text-size;
   font-weight: $typography-bold-font-weight;
   color: colour-var("accent-button-text");
   text-decoration: none;
 
   background-color: brand-colour("navy");
-  border: 0;
 
   &:focus,
   &:hover {
     @include focus-default;
 
+    border-color: brand-colour("navy");
+
     color: colour-var("accent-button-text");
     text-decoration: underline;
 
     background-color: brand-colour("navy");
-    border-color: brand-colour("navy");
     outline-color: brand-colour("navy");
     outline-offset: 0.2rem;
   }
@@ -33,9 +34,9 @@
 @mixin button-secondary {
   @include button-primary;
 
+  border: 2px solid brand-colour("navy");
   color: brand-colour("navy");
   background-color: transparent;
-  border: 2px solid brand-colour("navy");
 
   &:hover,
   &:focus,
@@ -90,12 +91,12 @@
   cursor: pointer;
 
   padding: 0 !important;
+  border: none;
 
   font-size: $typography-md-text-size;
   text-decoration: underline;
 
   background: none !important;
-  border: none;
 
   @include link;
 }

ds_judgements_public_ui/sass/includes/_judgment_text_download_options.scss

@@ -24,7 +24,6 @@
     align-items: center;
 
     padding: $space-6;
-
     border: 2px solid $color-yellow;
 
     .btn {

ds_judgements_public_ui/sass/includes/_judgment_text_end_document_marker.scss

@@ -4,12 +4,11 @@
   height: $space-4;
   margin: auto;
   margin-bottom: $space-17;
-
-  text-align: center;
-
   border: 1px dashed colour-var("black");
   border-top: none;
 
+  text-align: center;
+
   &__top-link {
     display: inline-block;
     padding: $space-2;

ds_judgements_public_ui/sass/includes/_judgments_listing.scss

@@ -13,7 +13,6 @@
       gap: $space-4;
 
       padding: $space-4 $space-1;
-
       border-bottom: 1px dotted $color-yellow;
     }
   }

ds_judgements_public_ui/sass/includes/_mixins.scss

@@ -63,8 +63,8 @@
 
 @mixin emphasised-block {
   padding: $space-4;
-  background-color: colour-var("accent-background-light");
   border-left: 0.5rem solid brand-colour("navy");
+  background-color: colour-var("accent-background-light");
 }
 
 @mixin focus-default {
@@ -102,12 +102,12 @@
   margin-top: $space-2;
   margin-bottom: $space-4;
   padding: $space-2;
+  border: 2px solid colour-var("input-border");
 
   font-family: $font-open-sans;
   font-size: $typography-md-text-size;
 
   background-color: colour-var("input-background");
-  border: 2px solid colour-var("input-border");
 
   &:focus {
     @include focus-default;
@@ -120,6 +120,8 @@
   margin-top: $space-2;
   margin-bottom: $space-4;
   padding: $space-2;
+  border: 2px solid colour-var("input-border");
+  border-radius: 0;
 
   font-size: $typography-md-text-size;
   line-height: $typography-lg-line-height;
@@ -135,8 +137,6 @@
   background-size:
     0.65rem auto,
     100%;
-  border: 2px solid colour-var("input-border");
-  border-radius: 0;
 
   &::-ms-expand {
     display: none;

ds_judgements_public_ui/sass/includes/_recent_judgments.scss

@@ -11,8 +11,8 @@
     @include header($typography-header-h2-size);
 
     padding-bottom: $space-6;
-    font-size: $typography-xl-text-size;
     border-bottom: 5px solid $color-yellow;
+    font-size: $typography-xl-text-size;
 
     @media (max-width: $grid-breakpoint-medium) {
       margin-top: 0;
@@ -25,23 +25,21 @@
     position: relative;
 
     padding: 0 0 $space-2;
+    border: 0;
 
     font-family: $font-roboto;
     font-size: 1rem;
     font-weight: $typography-normal-font-weight;
 
-    border: 0;
-
     a {
       display: inline-block;
 
       margin: $space-1 0;
       padding: $space-1 0;
+      border-bottom: 0.125rem solid colour-var("accent-link");
 
       color: colour-var("accent-link");
       text-decoration: none;
-
-      border-bottom: 0.125rem solid colour-var("accent-link");
     }
   }
 

ds_judgements_public_ui/sass/includes/_results.scss

@@ -53,7 +53,6 @@
     gap: $space-4;
 
     padding-bottom: $space-4;
-
     border-bottom: 1px solid $color-yellow;
 
     @media (min-width: $grid-breakpoint-extra-large) {

ds_judgements_public_ui/sass/includes/_results_search_component.scss

@@ -89,11 +89,11 @@
   &__fieldset {
     margin: $space-1;
     padding: $space-8;
+    border: 0;
 
     color: colour-var("accent-font-base");
 
     background: $color-yellow;
-    border: 0;
   }
 
   &__help-text {
@@ -201,12 +201,11 @@
     display: inline-block;
 
     padding: $space-2 $space-2 $space-2 $space-4;
+    border: 0.188rem solid $color-yellow;
 
     color: colour-var("accent-link");
     text-decoration: none;
 
-    border: 0.188rem solid $color-yellow;
-
     &:hover {
       color: colour-var("accent-link");
       background: $color-yellow;
@@ -242,13 +241,13 @@
 
       margin: 0 auto;
       padding: 0 0 $space-2 $space-6;
+      border: none;
+      border-bottom: 0.188rem solid $color-yellow;
 
       font-size: $typography-md-text-size;
       font-weight: $typography-bold-font-weight;
 
       background-color: transparent;
-      border: none;
-      border-bottom: 0.188rem solid $color-yellow;
 
       &::after {
         content: "";
@@ -263,7 +262,6 @@
         width: 0.438rem;
         height: 0.438rem;
         margin: auto 0;
-
         border: solid;
         border-color: colour-var("font-base");
         border-width: 0.125rem 0.125rem 0 0;

ds_judgements_public_ui/sass/includes/_structured_search.scss

@@ -144,9 +144,9 @@
     flex-direction: column;
 
     padding: $space-4;
+    border-top: 4px solid $color-yellow;
 
     background-color: colour-var("accent-background-light");
-    border-top: 4px solid $color-yellow;
 
     @media (max-width: $grid-breakpoint-medium) {
       margin-bottom: $space-4;
@@ -158,9 +158,9 @@
     flex-direction: column;
 
     padding: $space-4;
+    border-top: 4px solid $color-yellow;
 
     background-color: colour-var("accent-background-light");
-    border-top: 4px solid $color-yellow;
 
     @media (max-width: $grid-breakpoint-medium) {
       margin-bottom: $space-4;
@@ -245,13 +245,13 @@
         width: $space-6;
         height: $space-6;
         margin: 0;
+        border: 2px solid colour-var("input-border");
 
         font: inherit;
         color: colour-var("input-foreground");
 
         appearance: none;
         background-color: colour-var("input-background");
-        border: 2px solid colour-var("input-border");
 
         &::before {
           content: "";

ds_judgements_public_ui/sass/includes/govuk_overrides/_header.scss

@@ -1,6 +1,6 @@
 .govuk-header {
-  background-color: colour-var("contrast-background");
   border-bottom: none;
+  background-color: colour-var("contrast-background");
 }
 
 .govuk-header__link--homepage:hover,
@@ -12,10 +12,10 @@
 .govuk-header__navigation-item--active .govuk-header__link:hover,
 .govuk-header__navigation-item--active .govuk-header__link:visited,
 .govuk-header__navigation-item--active a:link {
+  border-bottom: 0.25rem solid $color-yellow;
   font-weight: bold !important;
   color: $color-yellow;
   text-decoration: none;
-  border-bottom: 0.25rem solid $color-yellow;
 
   &:focus {
     background-color: transparent;
@@ -29,9 +29,9 @@
 
 .govuk-header__link {
   &:hover {
+    border-bottom: none;
     color: colour-var("contrast-link");
     text-decoration: none !important;
-    border-bottom: none;
   }
 
   &:focus {

ds_judgements_public_ui/sass/includes/govuk_overrides/_warning_text.scss

@@ -30,7 +30,6 @@
   font-weight: $typography-normal-font-weight;
 
   background-color: brand-colour("pastel-blue");
-  border: transparent;
 
   @media (min-width: $grid-breakpoint-medium) {
     width: 100%;

ds_judgements_public_ui/sass/includes/vendors/_home_office.scss

@@ -9,11 +9,11 @@
   margin-top: $space-5;
   margin-bottom: $space-5;
   padding: $space-4;
+  border-left: 10px solid $home-office-alert-border-colour;
 
   font-size: $typography-md-text-size;
 
   background-color: $home-office-alert-background-colour;
-  border-left: 10px solid $home-office-alert-border-colour;
 
   > *:first-child,
   &:first-child {
@@ -27,13 +27,13 @@
   }
 
   &--error {
-    background-color: $home-office-alert-error-background-colour;
     border-color: $home-office-alert-error-border-colour;
+    background-color: $home-office-alert-error-background-colour;
   }
 
   &--success {
-    background-color: $home-office-alert-success-background-colour;
     border-color: $home-office-alert-success-border-colour;
+    background-color: $home-office-alert-success-background-colour;
   }
 
   &__heading {

ds_judgements_public_ui/templates/includes/judgment_text_toolbar.html

@@ -25,7 +25,7 @@ <h1 id="judgment-toolbar-title" class="judgment-toolbar__title">{{ document|get_
         {% endspaceless %}
       {% endif %}
       {% if document.best_human_identifier %}
-          <a href="#download-options" class="judgment-toolbar__download-options-link"  aria-label="View download options">View download options</a>
+        <a href="#download-options" class="judgment-toolbar__download-options-link"  aria-label="View download options">View download options</a>
       {% endif %}
     </div>
   </div>