fix(android): prevent error because of N bug

NativeScript/NativeScript#10441
nativescript-community · Nov 19, 2023 · be1ed23 · be1ed23
1 parent 28202de
commit be1ed23
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/core/index.android.ts b/src/core/index.android.ts
@@ -203,7 +203,9 @@ export function getRippleColor(color: string | Color, alpha = 0) {
         if (temp.a !== 255 && alpha === 0) {
             return temp.android;
         }
-        return temp.setAlpha(alpha || 61.5).android;
+        // TODO: we cant use setAlpha until it is fixed in Nativescript or android will be undefined
+        return new Color(alpha || 61.5, temp.r, temp.g, temp.b).android;
+        // return temp.setAlpha(alpha || 61.5).android;
     }
     return null;
 }

diff --git a/src/ripple/ripple.android.ts b/src/ripple/ripple.android.ts
@@ -231,9 +231,9 @@ export class Ripple extends RippleBase {
                 Length.toDevicePixels(this.style.borderBottomLeftRadius)
             );
         } else {
-            const nColor = getRippleColor(color, this.rippleColorAlpha)
+            const nColor = getRippleColor(color, this.rippleColorAlpha);
             if (isPostLollipopMR1) {
-                (this.rippleDrawable as android.graphics.drawable.RippleDrawable).setColor(color?getColorStateList(nColor):null);
+                (this.rippleDrawable as android.graphics.drawable.RippleDrawable).setColor(color ? getColorStateList(nColor) : null);
             } else {
                 (this.rippleDrawable as any).rippleShape.getPaint().setColor(nColor);
             }