Merge pull request #622 from ripienaar/consumer_clarify

Clarify consumer config
nats-io · Jan 27, 2025 · 62a6bf0 · 62a6bf0
2 parents ce931af + 8019d5f
commit 62a6bf0
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 36 deletions.
diff --git a/schema_source/jetstream/api/v1/definitions.json b/schema_source/jetstream/api/v1/definitions.json
@@ -687,11 +687,7 @@
       }
     },
     "consumer_configuration": {
-      "required":[
-        "deliver_policy",
-        "ack_policy",
-        "replay_policy"
-      ],
+      "required":[],
       "allOf": [{"$ref": "#/definitions/deliver_policy"}],
       "properties": {
         "durable_name": {
@@ -715,7 +711,7 @@
           "default": "all"
         },
         "deliver_subject": {
-          "description": "The subject to delivery messages to",
+          "description": "The subject push consumers delivery messages to",
           "type": "string",
           "minLength": 1
         },

diff --git a/schemas/jetstream/api/v1/consumer_configuration.json b/schemas/jetstream/api/v1/consumer_configuration.json
@@ -4,11 +4,7 @@
   "description": "The data structure that describe the configuration of a NATS JetStream Consumer",
   "title": "io.nats.jetstream.api.v1.consumer_configuration",
   "type": "object",
-  "required": [
-    "deliver_policy",
-    "ack_policy",
-    "replay_policy"
-  ],
+  "required": [],
   "allOf": [
     {
       "oneOf": [
@@ -139,7 +135,7 @@
       "default": "all"
     },
     "deliver_subject": {
-      "description": "The subject to delivery messages to",
+      "description": "The subject push consumers delivery messages to",
       "type": "string",
       "minLength": 1
     },

diff --git a/schemas/jetstream/api/v1/consumer_create_request.json b/schemas/jetstream/api/v1/consumer_create_request.json
@@ -16,11 +16,7 @@
     "config": {
       "type": "object",
       "description": "The consumer configuration",
-      "required": [
-        "deliver_policy",
-        "ack_policy",
-        "replay_policy"
-      ],
+      "required": [],
       "allOf": [
         {
           "oneOf": [
@@ -151,7 +147,7 @@
           "default": "all"
         },
         "deliver_subject": {
-          "description": "The subject to delivery messages to",
+          "description": "The subject push consumers delivery messages to",
           "type": "string",
           "minLength": 1
         },

diff --git a/schemas/jetstream/api/v1/consumer_create_response.json b/schemas/jetstream/api/v1/consumer_create_response.json
@@ -38,11 +38,7 @@
           "format": "date-time"
         },
         "config": {
-          "required": [
-            "deliver_policy",
-            "ack_policy",
-            "replay_policy"
-          ],
+          "required": [],
           "allOf": [
             {
               "oneOf": [
@@ -173,7 +169,7 @@
               "default": "all"
             },
             "deliver_subject": {
-              "description": "The subject to delivery messages to",
+              "description": "The subject push consumers delivery messages to",
               "type": "string",
               "minLength": 1
             },

diff --git a/schemas/jetstream/api/v1/consumer_info_response.json b/schemas/jetstream/api/v1/consumer_info_response.json
@@ -38,11 +38,7 @@
           "format": "date-time"
         },
         "config": {
-          "required": [
-            "deliver_policy",
-            "ack_policy",
-            "replay_policy"
-          ],
+          "required": [],
           "allOf": [
             {
               "oneOf": [
@@ -173,7 +169,7 @@
               "default": "all"
             },
             "deliver_subject": {
-              "description": "The subject to delivery messages to",
+              "description": "The subject push consumers delivery messages to",
               "type": "string",
               "minLength": 1
             },

diff --git a/schemas/jetstream/api/v1/consumer_list_response.json b/schemas/jetstream/api/v1/consumer_list_response.json
@@ -103,11 +103,7 @@
                 "format": "date-time"
               },
               "config": {
-                "required": [
-                  "deliver_policy",
-                  "ack_policy",
-                  "replay_policy"
-                ],
+                "required": [],
                 "allOf": [
                   {
                     "oneOf": [
@@ -238,7 +234,7 @@
                     "default": "all"
                   },
                   "deliver_subject": {
-                    "description": "The subject to delivery messages to",
+                    "description": "The subject push consumers delivery messages to",
                     "type": "string",
                     "minLength": 1
                   },