Add noop for stream and consumer (#112)

Signed-off-by: Jarema <[email protected]>
nats-io · Feb 21, 2023 · f9408bd · f9408bd
1 parent 5f28a9d
commit f9408bd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/controllers/jetstream/consumer.go b/controllers/jetstream/consumer.go
@@ -217,7 +217,12 @@ func (c *Controller) processConsumerObject(cns *apis.Consumer, jsmc jsmClient) (
 			return err
 		}
 	default:
-		c.warningEvent(cns, "Noop", fmt.Sprintf("Nothing done for consumer %q", spec.DurableName))
+		c.normalEvent(cns, "Noop", fmt.Sprintf("Nothing done for consumer %q (prevent-delete=%v, prevent-update=%v)",
+			spec.DurableName, spec.PreventDelete, spec.PreventUpdate,
+		))
+		if _, err := setConsumerOK(c.ctx, cns, ifc); err != nil {
+			return err
+		}
 	}
 
 	return nil

diff --git a/controllers/jetstream/stream.go b/controllers/jetstream/stream.go
@@ -255,7 +255,13 @@ func (c *Controller) processStreamObject(str *apis.Stream, jsmc jsmClient) (err
 			return err
 		}
 	default:
-		c.warningEvent(str, "Noop", fmt.Sprintf("Nothing done for stream %q", spec.Name))
+		c.normalEvent(str, "Noop", fmt.Sprintf("Nothing done for stream %q (prevent-delete=%v, prevent-update=%v)",
+			spec.Name, spec.PreventDelete, spec.PreventUpdate,
+		))
+		// Noop events only update the status of the CRD.
+		if _, err := setStreamOK(c.ctx, str, ifc); err != nil {
+			return err
+		}
 	}
 
 	return nil