Fix message parsing in nats resolver account deletion handling #6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a call to `c.msgParts` for proper parsing of message contents in the account deletion request handler. Tests pass without this change, but an actual call of the API will always fail to parse the request JWT because the delete function only expects the JWT portion:
```
NATS/1.0
Nats-Request-Info: {"acc":"AA3SRJHT6PP52IJG26AXNSA7DYOCOZCWZARDOPVLMPGV45QBKRLGEVNW","rtt":899875,"server":"NBK7H52ED2O6XYMB5E6YTQIZPVKCF6BQN4G7XDEZ3GPGJU25K3DDTEQN"}
eyJ0eXAiOiJKV1QiLCJhbGciOiJlZDI1NTE5LW5rZXkifQ.eyJqdGkiOiJTVUQ1VVY1T1ZERDJUSDJaSUNIWU5LTlNUWFZESk1IT0E2Q1ZUWldXTklFT0UyVlhLVEdRIiwiaWF0IjoxNzM4MTcxNTk3LCJpc3MiOiJPQUZNWVVYMk83RjZVTzNITUtOV0ozMzdDNEtWT1BLNFVKQ0gyWUtPR042NDVHWlVRRVc2WVZIRCIsInN1YiI6Ik9BRk1ZVVgyTzdGNlVPM0hNS05XSjMzN0M0S1ZPUEs0VUpDSDJZS09HTjY0NUdaVVFFVzZZVkhEIiwibmF0cyI6eyJhY2NvdW50cyI6WyJBRE1BQ1QzNks0Uk41RDI2R0tKUUpOVEdDUEpVVEhPRU9TSEtITVBZTko1RDRLVFZWSlVBVlNJWiJdLCJ2ZXJzaW9uIjoyfX0.7G8PEXRIdPbN9pyjUorrngbnKTjzMATy9eL7u8f62zAECPZgIs4c2xDeA8nKgW1yRKFfdWBL872W8d8YmdJGDg
```
Signed-off-by: Alberto Ricart <[email protected]>
|
Is this PR ready for review? |
yes - was waiting for travis to pass the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a call to
c.msgPartsfor proper parsing of message contents in the account deletion request handler. Tests pass without this change, but an actual call of the API will always fail to parse the request JWT because the delete function only expects the JWT portion:Note that since this feature doesn't currently work, it means that it is not used, and I am not sure what the wisdom is on deleting accounts from the resolver, so possibly OK to leave as is.
Signed-off-by: alberto [email protected]