-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pause and resume jetstream consumer #1571
Conversation
181cd77
to
481ab36
Compare
808189f
to
12b1e06
Compare
12fa780
to
e17e2a9
Compare
I need help with:
|
In jsm.go - that is the underlying library for the CLI I added:
CLI got:
So seems good to me to have pause and resume behaviors in APIs, the original ask from the server was to have a Resume API also but we decided to take a bit of a shortcut with the nil time behavior. I think client facing be good to have Pause/Resume both. |
5e31e66
to
fb007dd
Compare
Signed-off-by: Yordis Prieto <[email protected]>
Hey guys, any update over here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, LGTM!
I changed the target branch to v2.11-dev
since we don't want to merge to main until the feature is released on the server.
Waiting to be merge so I move to the Elixir version |
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
Signed-off-by: Yordis Prieto <[email protected]>
closes #1569