Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for time-bar aggregation #2391

Merged

Conversation

stefansimik
Copy link
Contributor

Pull Request

With @faysou , we made an excellent team today and divided the tasks between us.

  • while @faysou was focusing on the fix PR#2930
  • I prepared the test in the meantime, that should ensure any similar problem will detected easily in the future

This test fails and indicates problem when composite bars aggregation stops working.

Type of change

Just new test

How has this change been tested?

Describe how this code was/is tested.

  • before @faysou's fix - the test "successfully" fails and indicates that there's any problem with bar aggregation that stopped working
  • after @faysou's fix - the test runs smoothly

This test fails and indicates problem when composite bars aggregation stops working.
@faysou
Copy link
Collaborator

faysou commented Mar 1, 2025

Thanks for this, the test looks good. I was thinking it's hard to piece together all components together for testing this properly, but the way you do with the low level API and using the experience from your examples works well instead.

@cjdsellers cjdsellers merged commit 7191b3e into nautechsystems:develop Mar 2, 2025
12 checks passed
@stefansimik stefansimik deleted the test_bar_aggregation branch March 2, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants