update to fix mtu int error #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susanhooks
requested review from
mzbroch,
scetron,
glennmatthews and
chadell
as code owners
This started when the models were first defined, it turned out to be easier to default to strings for all the data parsed from a device and handle any required conversions when the object was saved. |
|
Addresses Issue #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix added in is lines 93-98. The rest is formatting.
Discovered when building a fresh instance from develop, using SSoT 3.1.0 and dependencies, a Pydantic error was raised when running the sync network data job on the interface field MTU. Added in an override to force a string on this field.