Replace managed_policy_arns with aws_iam_role_policy_attachment
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like CI is failing because you need to detach the policies before you can delete them https://github.com/navapbc/platform-test/actions/runs/12897889821/job/35963884480?pr=162#step:6:5626 |
|
@coilysiren I looked into it. Look at this post hashicorp/terraform-provider-aws#39818 Solution: Switch to using aws_iam_role_policy_attachment, not aws_iam_role_policy_attachments_exclusive Maybe add a comment |
|
@lorenyu ahah! thanks |
lorenyu
approved these changes
Jan 31, 2025
coilysiren
changed the title
coilysiren
changed the title
managed_policy_arns with aws_iam_role_policy_attachment
coilysiren
added a commit
to navapbc/template-infra
that referenced
this pull request
Feb 13, 2025
…862) ## Context #785 This PR fixes deprecation warning linked in the above ticket ## Testing / Validation see: navapbc/platform-test#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
navapbc/template-infra#785
This PR fixes deprecation warning linked in the above ticket
Testing / Validation
Before & After, you'll notice that the same policy is attached
Preview environment for app
Preview environment for app-rails