CLEANUP: Reduce indent depth of SMGetResult merge method. #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Dec 27, 2023
| if (comp == 0) { | ||
| // Duplicated bkey. Compare the "cache key". | ||
| int keyComp = result.compareKeyTo(mergedResult.get(pos)); | ||
| if (unique) { |
There was a problem hiding this comment.
이 부분 로직이 변경된 것 같은 데, 확인 바랍니다.
| private void mergeTrimmedKeys(final List<SMGetTrimKey> eachTrimmedResult) { | ||
| if (eachTrimmedResult.isEmpty()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
다른 경우에서도 eachResult가 empty인 경우 return 하는 코드가 없기 때문에,
일관되게 위의 if 문은 제거해도 될 것 같습니다.
uhm0311
force-pushed
the
uhm0311/develop4
branch
from
3c7766a to
3e17041
Compare
uhm0311
force-pushed
the
uhm0311/develop4
branch
from
3e17041 to
c038e13
Compare
|
반영했습니다. |
jhpark816
reviewed
Dec 27, 2023
| } | ||
| if (!doInsert) { // UNIQUE | ||
|
|
||
| if (comp != 0) { |
There was a problem hiding this comment.
현재는 단순 리팩토링이므로, 여기 부분을 그대로 유지하면 좋겠습니다.
if (comp == 0) {
// Duplicated bkey. ....
...
}여기 코드를 이해하기 쉬운 코드로 리팩토링한다면, 충분히 다른 코드가 될 수도 있습니다.
이러한 리팩토링 시에 다시 조정하면 좋겠습니다.
There was a problem hiding this comment.
indentation depth만 줄이려는 데 너무 초점이 맞춰져 있는 것 같기도 합니다.
중간에 continue하는 것보다 기존 코드가 읽기에도 나은 것 같습니다.
uhm0311
force-pushed
the
uhm0311/develop4
branch
from
c038e13 to
243fc34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old, New 포함 SMGetResult의 Merge 메소드의 불필요한 Indent Depth를 줄였습니다.