Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Remove TranscodeService. #718

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

brido4125
Copy link
Collaborator

@brido4125 brido4125 commented Jan 24, 2024

앞선 PR들로인해 tcService를 더이상 사용하지 않으므로
해당 필드를 memcacedClient에서 삭제하였습니다.

@jhpark816
TcService와 테스트 코드 자체를 삭제할까요?

@brido4125 brido4125 self-assigned this Jan 24, 2024
@jhpark816 jhpark816 requested a review from uhm0311 January 24, 2024 07:15
@uhm0311
Copy link
Collaborator

uhm0311 commented Jan 24, 2024

제가 생각하기에는 TranscodeService 클래스는 완전히 제거하는 것이 좋다고 봅니다.

@jhpark816
Copy link
Collaborator

TranscodeService 클래스도 같이 제거합시다.

@uhm0311
Copy link
Collaborator

uhm0311 commented Jan 24, 2024

커밋 메세지를 다음과 같이 합시다.

  • INTERNAL: Remove TranscodeService.

@brido4125 brido4125 changed the title INTERNAL: Remove tcService in MemcachedClient. INTERNAL: Remove TranscoderService. Jan 24, 2024
@jhpark816
Copy link
Collaborator

Remove TranscoderService => Remove TranscodeService

@brido4125 brido4125 changed the title INTERNAL: Remove TranscoderService. INTERNAL: Remove TranscodeService. Jan 24, 2024
@jhpark816 jhpark816 merged commit 3bb0cd7 into naver:develop Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants