-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTERNAL: Add new merge method with improved performance to new SMGetResult. #720
Conversation
@oliviarla @brido4125 리뷰 바랍니다. |
src/main/java/net/spy/memcached/internal/result/SMGetResultImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/spy/memcached/internal/result/SMGetResultImpl.java
Outdated
Show resolved
Hide resolved
@uhm0311 |
801ddf6
to
c638ddd
Compare
위 PR의 변경사항을 반영했으며, 일부 변수명을 더 이해하기 쉽게 바꿨습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료
eachPos++; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아래와 같이 표현하시죠.
bkeyDuplicated = false;
comp = eachElem.compareBkeyTo(oldMergedElem);
if (comp == 0) { /* Compare the "cache key" */
bkeyDuplicated = true;
comp = eachElem.compareKeyTo(oldMergedElem);
assert comp != 0 : "Unexpected smget elements.";
}
if ((reverse) ? (comp > 0) : (comp < 0)) {
newMergedResult.add(eachElem);
eachPos++;
if (unique && bkeyDuplicated) oldMergedPos++;
} else {
newMergedResult.add(oldMergedElem);
oldMergedPos++;
if (unique && bkeyDuplicated) eachPos++;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다.
f0349ec
to
2cf0d76
Compare
91ac510
to
31690d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 완료
#715
위 PR의 New smget 버전입니다.
작업 방식은 위 PR과 동일합니다.