Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Add new merge method with improved performance to new SMGetResult. #720

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

uhm0311
Copy link
Collaborator

@uhm0311 uhm0311 commented Jan 26, 2024

#715

위 PR의 New smget 버전입니다.
작업 방식은 위 PR과 동일합니다.

@jhpark816
Copy link
Collaborator

@oliviarla @brido4125 리뷰 바랍니다.

@jhpark816
Copy link
Collaborator

@uhm0311
본 PR 처리 전에 trimmed keys 관리의 변경을 먼저 검토해야 할 것 같습니다. 참고 바랍니다.

@uhm0311 uhm0311 force-pushed the uhm0311/develop5 branch 2 times, most recently from 801ddf6 to c638ddd Compare March 25, 2024 07:00
@uhm0311
Copy link
Collaborator Author

uhm0311 commented Mar 25, 2024

#729

위 PR의 변경사항을 반영했으며, 일부 변수명을 더 이해하기 쉽게 바꿨습니다.

@uhm0311 uhm0311 requested review from brido4125 and oliviarla March 25, 2024 07:05
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

eachPos++;
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래와 같이 표현하시죠.

      bkeyDuplicated = false;
      comp = eachElem.compareBkeyTo(oldMergedElem);
      if (comp == 0) { /* Compare the "cache key" */
        bkeyDuplicated = true;
        comp = eachElem.compareKeyTo(oldMergedElem);
        assert comp != 0 : "Unexpected smget elements.";
      }
      if ((reverse) ? (comp > 0) : (comp < 0)) {
        newMergedResult.add(eachElem);
        eachPos++;
        if (unique && bkeyDuplicated) oldMergedPos++;
      } else {
        newMergedResult.add(oldMergedElem);
        oldMergedPos++;
        if (unique && bkeyDuplicated) eachPos++;
      }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다.

Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

@jhpark816 jhpark816 merged commit 79bc586 into naver:develop Mar 26, 2024
1 check passed
@uhm0311 uhm0311 deleted the uhm0311/develop5 branch March 28, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants