-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLEANUP: Refactored to remove unnecessary codes or redundancies. #91
Conversation
@oliviarla |
@@ -1336,8 +1322,7 @@ public void testPutIfAbsent_FrontCache_Null() { | |||
assertNull(exception); | |||
} | |||
|
|||
private static GetFuture<Object> createGetFuture( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맀κ°λ³μ λͺ μ value -> v λ‘ λ³κ²½νμ μ΄μ κ° λ¬΄μμΈκ°μ? μ μκ°μλ κ·Έλλ‘ λ¬λ λ κ² κ°μμμ!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value
λΌλ λ³μλͺ
μ΄ μ΄λκ°μμ κ²ΉμΉκΈ° λλ¬Έμ @SuppressWarnings("SameParameterValue")
κ° λΆμ κ±Έλ‘ μκ°νμ΅λλ€.
@SuppressWarnings("SameParameterValue")
λ₯Ό μ§μ°λ©΄μ κ²ΉμΉμ§ μλλ‘ λ³μλͺ
μ λ³κ²½νλλ°, κ·Έλλ‘ λ¬λ μλμ΄ λμ€μ§ μλ€μ.
@jhpark816 μ μκ°μ |
@uhm0311 |
λ°μνμ΅λλ€. |
π Related Issue
β¨οΈ What I did
λ¦΄λ¦¬μ¦ μ λ§μ§λ§ 컀λ°μΌλ‘, μλμ μ¬νμ λ°μν©λλ€.
@SuppressWarnings
μ΄λ Έν μ΄μ μ κ±°@SuppressWarnings
μ κ²½μ° λ©μλ λ¨μλ‘ μ μ©λμ΄ μμΌλ©΄ ν΄λμ€ λ¨μλ‘ ν΅ν©String#toString()
λ©μλ νΈμΆ μ κ±°