Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEANUP: Refactored to remove unnecessary codes or redundancies. #91

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

uhm0311
Copy link
Collaborator

@uhm0311 uhm0311 commented Jun 20, 2024

πŸ”— Related Issue

⌨️ What I did

릴리즈 μ „ λ§ˆμ§€λ§‰ μ»€λ°‹μœΌλ‘œ, μ•„λž˜μ˜ 사항을 λ°˜μ˜ν•©λ‹ˆλ‹€.

  • λΆˆν•„μš”ν•œ importλ¬Έ 제거
  • λΆˆν•„μš”ν•œ @SuppressWarnings μ–΄λ…Έν…Œμ΄μ…˜ 제거
  • ν•„μš”ν•œ @SuppressWarnings의 경우 λ©”μ†Œλ“œ λ‹¨μœ„λ‘œ μ μš©λ˜μ–΄ 있으면 클래슀 λ‹¨μœ„λ‘œ 톡합
  • String#toString() λ©”μ†Œλ“œ 호좜 제거

@uhm0311 uhm0311 requested a review from jhpark816 June 20, 2024 01:23
@jhpark816 jhpark816 requested a review from oliviarla June 20, 2024 01:49
@jhpark816
Copy link
Contributor

jhpark816 commented Jun 20, 2024

ν•„μš”ν•œ @SuppressWarnings의 경우 λ©”μ†Œλ“œ λ‹¨μœ„λ‘œ μ μš©λ˜μ–΄ 있으면 클래슀 λ‹¨μœ„λ‘œ 톡합

@oliviarla
λ©”μ†Œλ“œ λ‹¨μœ„ λ˜λŠ” 클래슀 λ‹¨μœ„ 쀑 μ–΄λ–€ 섀정이 쒋은 지λ₯Ό 리뷰 λ°”λžλ‹ˆλ‹€.

@@ -1336,8 +1322,7 @@ public void testPutIfAbsent_FrontCache_Null() {
assertNull(exception);
}

private static GetFuture<Object> createGetFuture(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ§€κ°œλ³€μˆ˜ λͺ…을 value -> v 둜 λ³€κ²½ν•˜μ‹  μ΄μœ κ°€ λ¬΄μ—‡μΈκ°€μš”? μ œμƒκ°μ—λŠ” κ·ΈλŒ€λ‘œ 둬도 될 것 κ°™μ•„μ„œμš”!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valueλΌλŠ” λ³€μˆ˜λͺ…이 μ–΄λ”˜κ°€μ—μ„œ 겹치기 λ•Œλ¬Έμ— @SuppressWarnings("SameParameterValue")κ°€ 뢙은 걸둜 μƒκ°ν–ˆμŠ΅λ‹ˆλ‹€.
@SuppressWarnings("SameParameterValue")λ₯Ό μ§€μš°λ©΄μ„œ κ²ΉμΉ˜μ§€ μ•Šλ„λ‘ λ³€μˆ˜λͺ…을 λ³€κ²½ν–ˆλŠ”λ°, κ·ΈλŒ€λ‘œ 둬도 μ›Œλ‹μ΄ λ‚˜μ˜€μ§€ μ•Šλ„€μš”.

@oliviarla
Copy link
Collaborator

@jhpark816
λ©”μ„œλ“œ λ‹¨μœ„λ‘œ SuppressWarnings μ–΄λ…Έν…Œμ΄μ…˜μ„ 달면 μ–΄λŠ λ©”μ„œλ“œμ—μ„œ warning이 λ°œμƒν•˜λŠ”μ§€ νŒŒμ•…ν•˜κΈ° μ‰½μŠ΅λ‹ˆλ‹€.

제 생각에 ArcusCache ν΄λž˜μŠ€μ—μ„œλŠ” κΈ°μ‘΄λŒ€λ‘œ λ©”μ„œλ“œλ§ˆλ‹€ λΆ™μ΄λŠ” 것이 μ–΄λŠ λ©”μ„œλ“œμ—μ„œ warning이 λ°œμƒν•˜λŠ”μ§€ νŒŒμ•…ν•˜κΈ° μ‰¬μ›Œλ³΄μž…λ‹ˆλ‹€.
ArcusCacheTest ν΄λž˜μŠ€μ—μ„œλŠ” λͺ¨λ“  ν…ŒμŠ€νŠΈ λ©”μ„œλ“œμ— μ„€μ •λ˜μ–΄μžˆλŠ” μ–΄λ…Έν…Œμ΄μ…˜μ„ 클래슀 λ‹¨μœ„λ‘œ λͺ…μ‹œν•˜λŠ” 것이 였히렀 가독성이 쒋아보일 것 κ°™μŠ΅λ‹ˆλ‹€.

@jhpark816
Copy link
Contributor

λ©”μ„œλ“œ λ‹¨μœ„λ‘œ SuppressWarnings μ–΄λ…Έν…Œμ΄μ…˜μ„ 달면 μ–΄λŠ λ©”μ„œλ“œμ—μ„œ warning이 λ°œμƒν•˜λŠ”μ§€ νŒŒμ•…ν•˜κΈ° μ‰½μŠ΅λ‹ˆλ‹€.

  • 제 생각에 ArcusCache ν΄λž˜μŠ€μ—μ„œλŠ” κΈ°μ‘΄λŒ€λ‘œ λ©”μ„œλ“œλ§ˆλ‹€ λΆ™μ΄λŠ” 것이 μ–΄λŠ λ©”μ„œλ“œμ—μ„œ warning이 λ°œμƒν•˜λŠ”μ§€ νŒŒμ•…ν•˜κΈ° μ‰¬μ›Œλ³΄μž…λ‹ˆλ‹€.
  • ArcusCacheTest ν΄λž˜μŠ€μ—μ„œλŠ” λͺ¨λ“  ν…ŒμŠ€νŠΈ λ©”μ„œλ“œμ— μ„€μ •λ˜μ–΄μžˆλŠ” μ–΄λ…Έν…Œμ΄μ…˜μ„ 클래슀 λ‹¨μœ„λ‘œ λͺ…μ‹œν•˜λŠ” 것이 였히렀 가독성이 쒋아보일 것 κ°™μŠ΅λ‹ˆλ‹€.

@uhm0311
λ‚΄ 생각도 μœ„μ™€ 같은 μƒκ°μž…λ‹ˆλ‹€. κ°€λŠ₯ν•˜λ©΄ μœ„μ™€ 같이 ν•˜μ‹œμ£ .

@uhm0311
Copy link
Collaborator Author

uhm0311 commented Jun 20, 2024

@oliviarla

λ°˜μ˜ν–ˆμŠ΅λ‹ˆλ‹€.

@jhpark816 jhpark816 merged commit 13a5664 into naver:develop Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants