-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0.54.x features to docs #185
base: master
Are you sure you want to change the base?
Conversation
apt install ./navidrome_0.XX.X_linux_amd64.deb | ||
~~~ | ||
|
||
Using `dpkg`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a section for rpm-based?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any plans for this follow-up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried setting up a rpm distro, haven't decided if I'm going to or not. If someone else wants to tackle actually doing the installation for this section, that would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes. Let me know if you need help with those.
content/en/docs/Usage/backup.md
Outdated
|
||
Note: Restoring a backup should ONLY be done when the service is NOT running. | ||
|
||
Restore a backup by running the `navidrome backup restore` command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide fill example (need to specify path). Emphasize strongly that this should not be done on a live system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now that I have tested the restore with pr-3579 in place which requires the backup name, I get prompted to create a super admin on first start. Is that intentional? I see my other users also do not get restored, so all play counts are lost as well. Earlier in this doc, I call out that users and play counts are supposed to be part of the backup so I need to know if I'm hitting a bug or if I need to go edit the doc and state that users and play counts are NOT part of the restore process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely a failed restore. navidrome backup restore -b $PATH_TO_BACKUP
is supposed to restore everything as-is.
- Did you do it while Navidrome was running?
- Were there existing
*-shm
/--wal
files?
Can diagnose further in Discord
|
||
|
||
## Configuring Backup with Environment Variables | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide note that for systemd, if not in /var/lib/navidrome
, you may need to add the path to read write path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it fair to say that that ONLY applies to linux installations? manual, rpm, and deb? Or could systemd ever need configured for containerized ND services? I'm thinking I'd like to either put the notes on linux systems that run ND through systemd as part of the "Additional Considerations" at the bottom or create a separate section dedicated to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, only bare metal
@@ -72,7 +187,7 @@ WantedBy=multi-user.target | |||
User=<user> | |||
Group=<group> | |||
Type=simple | |||
ExecStart=/opt/navidrome/navidrome --configfile "/var/lib/navidrome/navidrome.toml" | |||
ExecStart=/opt/navidrome/navidrome --configfile "/etc/navidrome/navidrome.toml" | |||
WorkingDirectory=/var/lib/navidrome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially also note here, that you may need to update systemd service if backup is somewhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to leave this open for now and link to exact spot where that documentation lives once its in place.
apt install ./navidrome_0.XX.X_linux_amd64.deb | ||
~~~ | ||
|
||
Using `dpkg`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any plans for this follow-up?
No description provided.