ActionMenu component #3081
ActionMenu component #3081
Conversation
…lektert i descendants-map
| {children} | ||
| <Marker placement="left"> | ||
| <Menu.ItemIndicator className="navds-action-menu__indicator"> | ||
| <svg |
There was a problem hiding this comment.
There's something called SVG sprites. Don't know, but maybe this is a good use case.
There was a problem hiding this comment.
Check BEM:
- "navds-action-menu--marker" (maybe "navds-action-menu__item--has-icon") (two places)
- "navds-action-menu__checkbox" (maybe "navds-action-menu__item--checkbox")
- "navds-action-menu__radio" (maybe "navds-action-menu__item--radio")
- "navds-action-menu__sub-trigger" (maybe "navds-action-menu__item--sub-trigger")
There was a problem hiding this comment.
Updated navds-action-menu--marker -> navds-action-menu--has-icon
Unsure about the others, since they are both an item (element) and a checkbox/radio/subtrigger (element) 🤔 If we follow "BEM" to the definition, this would make sense
navds-action-menu__item-checkbox
navds-action-menu__item-radio
navds-action-menu__item-sub-trigger
What do you think?
There was a problem hiding this comment.
I would say they are different variants of an item. In BEM terms, navds-action-menu__item is the Element and navds-action-menu__item--checkbox is a Modifier.
Looks like the BEM docs doesn't mention it, but I don't think it makes sense to have multiple "element-classes" on the same element. When reading the CSS you will get the impression that they are separate elements.
Co-authored-by: Halvor Haugan <[email protected]>
…3194) * refactor: Remove extra CSS-classes, fixed center bug in safari * refactor: Removed unused CSS
…d of pointermove (#3193) * feat: ActionMenu now only opens submeny onClick * memo: removed TODO * feat: Closes all adjacent submenues when opening a new one * refactor: Undo unwrapping of onDismiss * refactor: Remove unused code in Menu.tsx * feat: Handle submenu keys correctly * feat: use native onClick for Trigger * refactor: Remove un-needed disabled check on trigger * bug: Reuse already used context * Update @navikt/core/react/src/overlays/floating-menu/Menu.tsx Co-authored-by: Halvor Haugan <[email protected]> * bug: Rename open prop * Memo: update comment * feat: Use looser types for RovingFocus * bug: Aboid auto-closing menu when opening with pointer --------- Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Description
ActionMenu will act as new and improved replacement for our
Dropdown, with functionality forTODO:
Examples and demonstrations for the website will be a new PR after this one is completed.