Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skal kunne legge til flere skoleårsperioder. Per nå er ikke hver dist… #2402

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

ViktorGSolberg
Copy link
Contributor

@ViktorGSolberg ViktorGSolberg commented Jun 28, 2023

…inkte skoleårsperiode-komponent synlig

Hvorfor er denne endringen nødvendig? ✨

I nytt GUI for skolepenger skal det være mulig å opprette flere skoleårsperioder. Denne PRen lar oss velge flere skoleårsperioder, men hver distinkte periode er fortsatt usynlig i GUIet. Neste PR vil implementere visning for Skoleperiode-komponenten.

Under har man valgt å legge til flere skoleperioder, men siden visning foreløpig ikke er implementert blir det kun lagt til litt spacing for hver Skoleperiode:
Skjermbilde 2023-06-28 kl  15 17 25

Denne komponenten er featureTogglet og vises kun for utvalgte saksbehandlere.

@ViktorGSolberg ViktorGSolberg requested a review from a team as a code owner June 28, 2023 13:18
Copy link
Contributor

@eirarset eirarset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (med unntak av byggfeil) 😅

@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eirarset eirarset merged commit d174f15 into master Jun 30, 2023
3 checks passed
@eirarset eirarset deleted the skolepenger-2.0-skoleperioder-komponent branch June 30, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants