Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis aiven #2446

Merged
merged 12 commits into from
Jul 24, 2023
Merged

Redis aiven #2446

merged 12 commits into from
Jul 24, 2023

Conversation

charliemidtlyng
Copy link
Contributor

@charliemidtlyng charliemidtlyng commented Jul 18, 2023 •
edited
Loading

Hvorfor er denne endringen nødvendig? ✨

For å få nedetidsfri håndtering av sesjoner må vi kjøre mot Aiven Redis, og ikke "hjemmesnekra" redis.

Må justere litt på konfigurasjonen ettersom vi nå får andre miljøvariabler inn.

Har justert familie-felles-frontend -> familie-backend til å ta imot disse parameterne.

Favro

@charliemidtlyng charliemidtlyng requested a review from a team as a code owner July 18, 2023 08:12
@charliemidtlyng
Copy link
Contributor Author

Må ikke merges med canary-versjon av familie-backend, men testes i preprod med denne versjonen

olekvernberg
olekvernberg reviewed Jul 18, 2023
View reviewed changes
src/backend/config.ts Outdated Show resolved Hide resolved
charliemidtlyng
charliemidtlyng commented Jul 19, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
eirarset
eirarset approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@eirarset eirarset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 👏

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@charliemidtlyng charliemidtlyng merged commit ec07c15 into master Jul 24, 2023
5 checks passed
@charliemidtlyng charliemidtlyng deleted the redis-aiven branch July 24, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirarset eirarset eirarset approved these changes

@ViktorGSolberg ViktorGSolberg ViktorGSolberg approved these changes

@olekvernberg olekvernberg olekvernberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charliemidtlyng @eirarset @ViktorGSolberg @olekvernberg