Skip to content

Commit

Permalink
Bruk node 20. Endre til nonroot i dockerfile (#1746)
Browse files Browse the repository at this point in the history
* Bruk :nonroot. Sett Workdir til /app

(cherry picked from commit cdb1f48)

* Bruk node 20 i github actions

(cherry picked from commit d51e6be)
  • Loading branch information
halvorbmundal authored Apr 17, 2024
1 parent 3003e47 commit 6c86b2b
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: yarn
registry-url: "https://npm.pkg.github.com"
- name: Yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_n_deploy_dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: yarn
registry-url: "https://npm.pkg.github.com"
- name: Yarn install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_n_deploy_prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'
cache: yarn
registry-url: "https://npm.pkg.github.com"
- name: Yarn install
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM gcr.io/distroless/nodejs20-debian12
FROM gcr.io/distroless/nodejs20-debian12:nonroot
WORKDIR /app

COPY assets ./assets
COPY node_dist ./node_dist
Expand Down

0 comments on commit 6c86b2b

Please sign in to comment.