Skip to content

Commit

Permalink
EY-4043: Kotlin 2 (#5703)
Browse files Browse the repository at this point in the history
* Skriv om til non-deprecated måte å setje ønkst JVM på

* Flyttar maven-avhengnad-blokk for libs saman med resten av dei

* Flyttar maven-avhengnad-blokk for libs saman med resten av dei

* Ser ut som Kotlin 2 er litt meir restriktiv på imports for test-avhengnadar, både til testar og til testFixtures, så køyrer bygg lokalt og legg til det kompilatoren klagar på fram til det funkar

* Går opp til nyaste kotlin-versjon

* Verkar som den nye kompilatoren er raskare, men krev minne, så skrur opp jvm-minne-verdiane for gradle-bygginga eit par hakk for å unngå OOM

* K2-kompilatoren køyrer visst helst i ein daemon som kan delast på tvers av parallelle bygg, men han har også modusar som er treigare, men meir garantert å funke. Kan bruke fallback til det viss den parallelle versjonen feilar av ein eller annan grunn. https://kotlinlang.org/docs/gradle-compilation-and-caches.html#kotlin-compiler-fallback-strategy

* Rettar åtvaring om at copy-metoden kan brukast for å omgå private constructor, ved å bruke consistent visibility-annoteringa

* Kan jo fint bruke meir minne også, vi har jo stort sett kraftige maskiner

* Tar bort unødig overstyring av fallbackstrategi
  • Loading branch information
madsop-nav authored Sep 5, 2024
1 parent 433ff4b commit 0193de3
Show file tree
Hide file tree
Showing 11 changed files with 25 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import no.nav.etterlatte.libs.common.tidspunkt.Tidspunkt
import java.time.LocalDate
import java.util.UUID

@ConsistentCopyVisibility
data class DoedshendelseInternal internal constructor(
val id: UUID = UUID.randomUUID(),
val avdoedFnr: String,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import no.nav.etterlatte.libs.common.person.Verge
import no.nav.etterlatte.libs.common.sak.SakId
import no.nav.pensjon.brevbaker.api.model.Felles

@ConsistentCopyVisibility
data class BrevbakerRequest internal constructor(
val kode: Brevbakerkode,
val letterData: Any,
Expand Down
17 changes: 6 additions & 11 deletions buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import ca.cutterslade.gradle.analyze.AnalyzeDependenciesTask
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
import org.jetbrains.kotlin.gradle.dsl.JvmTarget

plugins {
kotlin("jvm") version "2.0.20"
`kotlin-dsl`
alias(libs.plugins.cutterslade.analyze) apply true
}
Expand All @@ -15,13 +16,6 @@ repositories {
// name = "JCenter Gradle Plugins",
url = "https://dl.bintray.com/gradle/gradle-plugins",
)
maven {
url = uri("https://maven.pkg.github.com/navikt/pensjon-etterlatte-libs")
credentials {
username = "token"
password = System.getenv("GITHUB_TOKEN")
}
}
}

dependencies {
Expand All @@ -34,9 +28,10 @@ tasks {
withType<Wrapper> {
gradleVersion = "8.10"
}

withType<KotlinCompile> {
kotlinOptions.jvmTarget = JavaVersion.VERSION_21.toString()
kotlin {
compilerOptions {
jvmTarget.set(JvmTarget.JVM_21)
}
}
java {
sourceCompatibility = JavaVersion.VERSION_21
Expand Down
3 changes: 2 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
org.gradle.caching=true
org.gradle.parallel=true
org.gradle.configuration-cache=false
org.gradle.configuration-cache=false
org.gradle.jvmargs=-Xmx6000m -Xms1500m
2 changes: 2 additions & 0 deletions libs/etterlatte-database/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,6 @@ dependencies {
testFixturesImplementation(libs.test.testcontainer.jupiter)
testFixturesImplementation(libs.test.testcontainer.postgresql)
testFixturesImplementation(libs.database.flywaydb)
testFixturesImplementation(libs.database.hikaricp)
testFixturesImplementation(libs.database.kotliquery)
}
1 change: 1 addition & 0 deletions libs/etterlatte-kafka/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ dependencies {
testFixturesImplementation(libs.test.testcontainer.kafka)

testFixturesImplementation(libs.ktor2.servercontentnegotiation)
testFixturesImplementation(libs.kafka.clients)
}
7 changes: 7 additions & 0 deletions libs/etterlatte-ktor/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,14 @@ dependencies {
testImplementation(libs.test.jupiter.engine)
testImplementation(libs.test.kotest.assertionscore)
testImplementation(libs.test.mockk)
testImplementation(libs.ktor2.servertests)
testImplementation(libs.navfelles.mockoauth2server)

testFixturesImplementation(libs.navfelles.mockoauth2server)
testFixturesImplementation(libs.ktor2.servertests)
testFixturesImplementation(libs.navfelles.tokenvalidationktor2)
testFixturesImplementation(libs.ktor2.jackson)
testFixturesImplementation(libs.ktor2.servercontentnegotiation)
testFixturesImplementation(libs.ktor2.clientcontentnegotiation)
testFixturesImplementation(project(":libs:saksbehandling-common"))
}
3 changes: 3 additions & 0 deletions libs/etterlatte-ktor/src/main/kotlin/token/BrukerTokenInfo.kt
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ sealed class Systembruker(
override fun kanEndreOppgaverFor(ident: String?) = true
}

@ConsistentCopyVisibility
data class VanligSystembruker internal constructor(
override val ident: String,
override val jwtTokenClaims: JwtTokenClaims? = null,
) : Systembruker(ident, jwtTokenClaims)

@ConsistentCopyVisibility
data class HardkodaSystembruker private constructor(
val omraade: Systembrukere,
) : Systembruker(ident = omraade.appName, jwtTokenClaims = tokenMedClaims(mapOf(Claims.idtyp to APP))) {
Expand Down Expand Up @@ -88,6 +90,7 @@ data class HardkodaSystembruker private constructor(
}
}

@ConsistentCopyVisibility
data class Saksbehandler internal constructor(
val accessToken: String,
val ident: String,
Expand Down
1 change: 1 addition & 0 deletions libs/saksbehandling-common/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ dependencies {
api(libs.bundles.jackson)

implementation(libs.etterlatte.common)
testFixturesImplementation(libs.etterlatte.common)
implementation(libs.logging.logbackclassic)
compileOnly(libs.logging.slf4japi)

Expand Down
1 change: 1 addition & 0 deletions libs/saksbehandling-common/src/main/kotlin/EnvUtils.kt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ fun Map<String, String>.requireEnvValue(key: String) =
else -> value
}

@ConsistentCopyVisibility
data class Miljoevariabler private constructor(
val props: Map<String, String>,
) {
Expand Down
3 changes: 0 additions & 3 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
rootProject.name = "pensjon-etterlatte-saksbehandling"
plugins {
kotlin("jvm") version "1.9.23" apply false
}
include(
"apps:etterlatte-pdltjenester",
"apps:etterlatte-behandling",
Expand Down

0 comments on commit 0193de3

Please sign in to comment.