Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rydde opp i innsender for persongalleri #6886

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

sebassonav
Copy link
Contributor

@sebassonav sebassonav commented Jan 28, 2025

Innsender er en del av persongalleriert og vi ønsker at innsender skal være en gyldig identifikator derfor bør alle fnr strings i persongalleriet være av typen folkeregisteridentifikator i stedet for STRING, det har blitt lagt inn mye ræl der blanet annet systemnavn og saksbehandler som aldri ble brukt til noenting ellers i systemet.
Denne opplysningen ligger lagret som kilde på opplysningstypen.

Merk at enkelte persongallerier i grunnlag har innsender satt til "PESYS"
men dette er kun de med kilde = "PESYS"/"SAKSBEHANDLER"
så med sjekker i grunnlag på om innsender er folkereg ellers sette innsender = null .
Man da egentlig sette innsender i alle med oppslysningstype PERSONGALLERI_V1med innsender=PESYS/saksbehandler til null.

Kilden ser da feks slik ut for de med pesys/saksbehandler
{"tidspunkt":"2023-11-22T14:03:55.311652Z","type":"pesys"}
{"ident":"SAKSBEHANDLERIDENT","tidspunkt":"2022-04-24T09:03:01.493157Z","type":"saksbehandler"}

@sebassonav sebassonav requested a review from a team as a code owner January 28, 2025 12:25
@sebassonav sebassonav marked this pull request as draft January 28, 2025 12:25
Copy link
Contributor

@Watercolours Watercolours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sebassonav sebassonav marked this pull request as ready for review January 28, 2025 14:04
@sebassonav sebassonav requested a review from oyvindsh January 28, 2025 14:14
@sebassonav sebassonav merged commit e761c46 into main Jan 28, 2025
108 checks passed
@sebassonav sebassonav deleted the feature/rydde-opp-i-innsender-for-persongalleri branch January 28, 2025 14:42
@@ -7,6 +7,7 @@ import java.time.LocalDate
/*
innsender: Denne brukes til å indikere system eller saksbehandler ident(manuelt opprettet behandling) i tillegg til faktisk innsender(innbygger)
*/
// TODO: gjøre om alle strings her til Folkeregister identifikator
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doit after #7052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants