Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4B #114

Closed
wants to merge 6 commits into from
Closed

R4B #114

wants to merge 6 commits into from

Conversation

bwalsh
Copy link

@bwalsh bwalsh commented Dec 22, 2022

This PR addresses #110:

  • moves fhir/resources to fhir/resources/R4
  • creates R4B classes and tests

Currently, testing shows these validation errors:

fhir/resources/tests/test_activitydefinition.py - timingTiming null not allowed
fhir/resources/tests/test_implementationguide.py - url missing scheme
fhir/resources/tests/test_library.py -  url missing scheme
fhir/resources/tests/test_plandefinition.py - timingTiming null not allowed, url missing scheme
fhir/resources/tests/test_relatedperson.py -  url missing scheme

 
fhir/resources/tests/test_searchparameter.py - __root__ -> base field required, id ensure this value has at most 64 characters
tests/test_utils_xml.py -  Value is expected from the instance of <class 'fhir.resources.fhirprimitiveextension.FHIRPrimitiveExtension'>, but got type <class 'fhir.resources.R4.fhirprimitiveextension.FHIRPrimitiveExtension'> (type=value_error)

TODO: As far as I can tell, these errors are expected - given the example data.
I wonder if the example data needs to be tweaked in order to generate passing tests?

Please let me know if this is the right approach, feedback ,etc.
Motivated to get a R4B compatible and eventually 5.0 releases created.

@bwalsh
Copy link
Author

bwalsh commented Dec 22, 2022

TODO: As far as I can tell, these errors are expected - given the example data.
I wonder if the example data needs to be tweaked in order to generate passing tests?

@nazrulworld
Copy link
Owner

Hi @bwalsh thanks a lot for your PR.

  1. It is very important that all tests should pass through travis.
  2. I think we will not create a separate folder (sub-package) for R4, there is no major difference between R4 and R4B as far as I understand.

@bwalsh bwalsh marked this pull request as draft December 23, 2022 17:59
@nazrulworld
Copy link
Owner

98b19ec

@bwalsh
Copy link
Author

bwalsh commented Dec 24, 2022

@nazrulworld Hey! You beat me to it. Thanks very much.

@bwalsh bwalsh closed this Dec 24, 2022
@bwalsh
Copy link
Author

bwalsh commented Dec 24, 2022

@nazrulworld thanks again, are you going to release it on pypi?

@nazrulworld
Copy link
Owner

I hope that within the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants