Update Desktop Entry and AppStream metadata files #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to AppStream metadata: - fixed the license (GPL-3.0+ instead of GPL-3.0) - updated the project description and the screenshot - added the latest releases (1.8.0, 1.7.1) to the changelog
JakobDev
reviewed
Feb 20, 2024
src/platform/qt/rc/io.nanoboyadvance.NanoBoyAdvance.metainfo.xml
Outdated
Show resolved
Hide resolved
That's correct yes |
zefr0x
reviewed
Feb 23, 2024
|
I updated the files to the latest version in the flathub submission. I don't think they'll change anymore soon. |
|
@Vulcalien Thanks for your efforts. Should I go ahead and merge this already? |
Yep, I'm done with these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the
.desktopand.metainfo.xmlfiles, fixing a typo (pplication/x-agb-rom), adding the new releases to the changelog etcI also changed the project license from
GPL-3.0toGPL-3.0+(tell me if I'm wrong, I think NBA is GPL 3 or any later version).