Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pkg_resources with importlib #186

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Replace pkg_resources with importlib #186

merged 2 commits into from
Jul 31, 2024

Conversation

dougiesquire
Copy link
Collaborator

@dougiesquire dougiesquire commented Jul 30, 2024 •
edited
Loading

Change Summary

pkg_resources was used in ecgtools to get the version, but pkg_resources has been removed in Python 3.12. This PR replaces uses of pkg_resources with importlib.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI

@dougiesquire dougiesquire marked this pull request as draft July 30, 2024 12:15
@mgrover1 mgrover1 marked this pull request as ready for review July 31, 2024 00:50
@dougiesquire dougiesquire merged commit 198e61b into main Jul 31, 2024
8 checks passed
@dougiesquire dougiesquire deleted the issue185_replace_pkg_resources branch July 31, 2024 00:56
@dougiesquire dougiesquire restored the issue185_replace_pkg_resources branch July 31, 2024 00:56
@dougiesquire dougiesquire deleted the issue185_replace_pkg_resources branch July 31, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgrover1 mgrover1 mgrover1 approved these changes

@andersy005 andersy005 Awaiting requested review from andersy005

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: pkg_resources is deprecated and removed in Python 3.12
2 participants
@dougiesquire @mgrover1