Fix xml editor #47
Open
Fix xml editor #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapped tab_width with: - tabWidth (org.eclipse.ui.editors) - org.eclipse.jdt.core.formatter.tabulation.size (org.eclipse.jdt.core) - formatter_tab_size (org.eclipse.ant.ui) mapped indent_size with: - indentationSize (org.eclipse.wst.xml.core) - org.eclipse.jdt.core.formatter.indentation.size (org.eclipse.jdt.core)
This was referenced Jun 9, 2018
ncjones
approved these changes
Jun 10, 2018
|
@ncjones how am I expected to test this? There is no test at all for the visitor, and even if there were, what could I test exactly? Sorry I'm a bit lost there :) |
|
Hi Victor,
There's a basic integration test suite using SWTBot (like Selenium but for
Eclipse):
https://github.com/ncjones/editorconfig-eclipse/blob/master/editorconfig-eclipse-functional-test/src/main/java/com/ncjones/editorconfig/eclipse/test/EditorConfigTest.java
Instructions on running the suite are in this project's Readme. Hopefully
it's simple to add a test. If not then let me know and I'll take a look.
…On Sat, Jun 16, 2018, 11:51 PM Victor Noël ***@***.***> wrote:
@ncjones <https://github.com/ncjones> how am I expected to test this?
There is no test at all for the visitor, and even if there were, what could
I test exactly? Sorry I'm a bit lost there :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGiCKojm5fm1Tc87eso7ww7JHhvSzHuks5t9PE8gaJpZM4UhaZi>
.
|
|
@ncjones perfect, I didn't see it because I didn't get imported into eclipse with the other projects. Any reason why it's not part of the multi-module parent project? |
victornoel
force-pushed
the
fix-xml-editor
branch
from
02b4e04
to
f9fd53f
Compare
|
@ncjones check latest commits. |
|
@ncjones ping ? :) |
|
@ncjones maybe you have more time now? ;) thanks! |
|
Can anybody merge this branch which is two years old ? |
|
@ncjones Hey, any chance we can get this merged and a new version deployed? If you're busy can we make our own version and publish it to Eclipse marketplace? Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41 by setting xml editor indent size to 1 when using tabs.
This replaces #42 and I also cherry-picked the commit of #45. Si they can both be closed when this is merged.
I also used the latest version of editorconfig-core-java.