Apply suggestions from code review #1014
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name: Moodle Plugin CI | |
on: [push, pull_request] | |
jobs: | |
test: | |
runs-on: 'ubuntu-latest' | |
services: | |
postgres: | |
image: postgres:13 | |
env: | |
POSTGRES_USER: 'postgres' | |
POSTGRES_HOST_AUTH_METHOD: 'trust' | |
ports: | |
- 5432:5432 | |
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 3 | |
mariadb: | |
image: mariadb:10 | |
env: | |
MYSQL_USER: 'root' | |
MYSQL_ALLOW_EMPTY_PASSWORD: "true" | |
MYSQL_CHARACTER_SET_SERVER: "utf8mb4" | |
MYSQL_COLLATION_SERVER: "utf8mb4_unicode_ci" | |
ports: | |
- 3306:3306 | |
options: --health-cmd="mysqladmin ping" --health-interval 10s --health-timeout 5s --health-retries 3 | |
strategy: | |
fail-fast: false | |
matrix: | |
include: | |
- php: '8.2' | |
moodle-branch: 'master' | |
database: 'mariadb' | |
- php: '8.2' | |
moodle-branch: 'MOODLE_403_STABLE' | |
database: 'pgsql' | |
- php: '8.1' | |
moodle-branch: 'MOODLE_402_STABLE' | |
database: 'mariadb' | |
- php: '8.0' | |
moodle-branch: 'MOODLE_401_STABLE' | |
database: 'pgsql' | |
- php: '7.4' | |
moodle-branch: 'MOODLE_400_STABLE' | |
database: 'mariadb' | |
- php: '7.3' | |
moodle-branch: 'MOODLE_311_STABLE' | |
database: 'pgsql' | |
- php: '7.2' | |
moodle-branch: 'MOODLE_39_STABLE' | |
database: 'mariadb' | |
steps: | |
- name: Check out repository code | |
uses: actions/checkout@v3 | |
with: | |
path: plugin | |
- name: Setup PHP ${{ matrix.php }} | |
uses: shivammathur/setup-php@v2 | |
with: | |
php-version: ${{ matrix.php }} | |
extensions: ${{ matrix.extensions }} | |
ini-values: max_input_vars=5000 | |
# none to use phpdbg fallback. Specify pcov (Moodle 3.10 and up) or xdebug to use them instead. | |
coverage: none | |
- name: Initialise moodle-plugin-ci | |
if: ${{ matrix.php >= '7.4' }} | |
run: | | |
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4 | |
- name: Initialise moodle-plugin-ci v3 | |
if: ${{ matrix.php < '7.4' }} | |
run: | | |
composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^3 | |
- name: Set up environment | |
run: | | |
echo $(cd ci/bin; pwd) >> $GITHUB_PATH | |
echo $(cd ci/vendor/bin; pwd) >> $GITHUB_PATH | |
sudo locale-gen en_AU.UTF-8 | |
echo "NVM_DIR=$HOME/.nvm" >> $GITHUB_ENV | |
- name: Install moodle-plugin-ci | |
id: install_ci | |
run: | | |
moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1 | |
env: | |
DB: ${{ matrix.database }} | |
MOODLE_BRANCH: ${{ matrix.moodle-branch }} | |
MUSTACHE_IGNORE_NAMES: 'mobile_view_page_latest.mustache,mobile_view_page_ionic3.mustache' | |
- name: PHP Lint | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci phplint | |
- name: PHP Copy/Paste Detector | |
continue-on-error: true # This step will show errors but will not fail | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci phpcpd | |
- name: PHP Mess Detector | |
continue-on-error: true # This step will show errors but will not fail | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci phpmd | |
- name: Moodle Code Checker | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci codechecker --max-warnings 0 | |
- name: Moodle PHPDoc Checker | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' && matrix.php >= '7.4' }} | |
run: moodle-plugin-ci phpdoc --max-warnings 0 | |
- name: Moodle PHPDoc Checker v3 | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' && matrix.php < '7.4' }} | |
run: moodle-plugin-ci phpdoc | |
- name: Validating | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci validate | |
- name: Check upgrade savepoints | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci savepoints | |
- name: Mustache Lint | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci mustache | |
- name: Grunt | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci grunt --max-lint-warnings 0 || [ "$MOODLE_BRANCH" = 'MOODLE_39_STABLE' ] || [ "$MOODLE_BRANCH" = 'MOODLE_311_STABLE' ] | |
env: | |
MOODLE_BRANCH: ${{ matrix.moodle-branch }} | |
- name: PHPUnit tests | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci phpunit --fail-on-warning | |
- name: Behat features | |
if: ${{ !cancelled() && steps.install_ci.outcome == 'success' }} | |
run: moodle-plugin-ci behat --profile chrome | |
- name: Make sure cancelled jobs are marked as failures. | |
if: ${{ cancelled() }} | |
run: exit 1 |