Skip to content

Commit

Permalink
add duration-based grading method
Browse files Browse the repository at this point in the history
- Grade according to the duration of meeting attendance
- set the id with the name for non-registered users so we use it a unique identifier for the user.
- updating records of participants instate of adding new record in case if the non-registered user left the meeting and return

fixing some codes and try to fix phpunit test

add name condition

add a condition for checking the existence of the participant by name along with user id to avoid update existence record if the user id is null

this should pass the phpunit test

adding a condition to check the existence of a data in zoom_meeting_participants by name along with user id to prevent updating records of users with null id.

options for grading methods and display name

- Adding setting to choose the grading method.
- Adding setting to choose the display name.
- Removing the overlapped time when merging a participant record in duration.

get_participant_overlap_time

creating a function that properly calculate the overlap timing in the meeting reports.

Just make the code checker happier.

Update get_meeting_reports.php

forgot to include join_time field.

Creating a function to calculate users grades

- Creating a function to calculate users grades according to their duration in the meeting.
- Fixing the function get_participant_overlap_time().
- Move the code to calculate the grades outside the loop.
- return the original inserting data to the participants table.
- prevent inserting multiple data for exist record.
- not updating grades until the new grade is larger than the old one.

testing the new grading method

Notify teachers about grades

Send teachers a notification about grades in meeting according to duration.

test the notification

update tests

try preventResetByRollback() maybe messages test work!

try to make messages work

changing teacher role to editingteacher

change graders array key

fix message index

fix misspelling

Add and fix comments

remove wrong using class and fix some comments

check the existence of user after integer check

Try not to be spamy

As the task get_meeting_reports run, don't send notifications unless there is new records in meeting participants table

Help teacher to fine ungraded users

Narrowing the options for teachers needing to grade non-recognized students in participant meeting report.

Adding a function to get a list of users clicked (join meeting)
using this function and excluding already recognized students
displaying a list of the rest student in the notification message to teachers

try to solve null readers

try to skip error: Call to a member function get_events_select() on null on PHPUnit test.

Co-authored-by: Jonathan Champ <[email protected]>
  • Loading branch information
fmido88 and jrchamp committed Sep 30, 2023
1 parent 910bcd8 commit 2ec0e5b
Show file tree
Hide file tree
Showing 6 changed files with 874 additions and 27 deletions.
Loading

0 comments on commit 2ec0e5b

Please sign in to comment.