Update zoom record after populated from response #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchamp
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
This extra update will make sure that fields which Zoom is the source of truth for are also updated on the Moodle side. As long as populate_zoom_from_response() does not include any fields for which Moodle should be the source of truth, this should work well.
A future update should be able to reduce the number of update_record calls. For example, if the update_meeting() API call fails, then we don't want to save values locally that Zoom is the source of truth for. However, we would still want to save values locally that Moodle is the source of truth for.
smbader
force-pushed
the
fix/save_join_url
branch
from
9a33c8a
to
e13d89b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the zoom record in Moodle after populating the object from the response. This is good for fields that Zoom may have updated or sent back that aren't a part of the form such as join_url.
Fixes #303