Set log quietness based on supplied verbosity #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verbosity level
Currently the
verbosity
that's passed to IRT trainer is not being used to actually set the log levels. This PR simply disables the logging (to stdout) when verbosity is False.I intentionally did not set the global logging level based on it to not interfere with external settings.
With
verbose=True
:With
verbose=False
:Misc other change
I also removed the
print(subjects.size(), items.size())
because it looks more like a forgotten debug statement than anything aimed at the user. The same information is already available in the parsed model args anyway.Misc other chagne
I also removed the enumerated improtes because they're alredy collected when importing
py_irt_models
(__init__.py
). This way when one wants to add a new model, there's only one place that needs to have it imported, the module init file.Technically also the
import py_irt.models
is not needed because of thefrom py_irt.models import abstract_model
but it's better to be explicit.