Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0074 provide accuracy #131

Merged
merged 5 commits into from
Oct 31, 2018
Merged

0074 provide accuracy #131

merged 5 commits into from
Oct 31, 2018

Conversation

Steppschuh
Copy link
Contributor

Closes #74

@codecov-io
Copy link

codecov-io commented Oct 30, 2018 •
edited
Loading

Codecov Report

Merging #131 into dev will increase coverage by 0.13%.
The diff coverage is 41.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #131      +/-   ##
============================================
+ Coverage     39.43%   39.57%   +0.13%     
- Complexity      235      236       +1     
============================================
  Files            40       40              
  Lines          1344     1362      +18     
  Branches        131      134       +3     
============================================
+ Hits            530      539       +9     
- Misses          762      771       +9     
  Partials         52       52
Impacted Files Coverage Δ Complexity Δ
...exenio/bleindoorpositioning/IndoorPositioning.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...bleindoorpositioning/ble/beacon/BeaconManager.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ning/location/multilateration/Multilateration.java 18.6% <100%> (+3.97%) 2 <0> (ø) ⬇️
...io/bleindoorpositioning/location/LocationUtil.java 80% <100%> (+1.87%) 7 <0> (ø) ⬇️
...exenio/bleindoorpositioning/location/Location.java 76.34% <46.15%> (-1.57%) 27 <2> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87af97...c5938e7. Read the comment docs.

@hadiidbouk
Copy link

Hello,

Can you explain more what you have done here, please?

@Steppschuh
Copy link
Contributor Author

Can you explain more what you have done here, please?

I've added an accuracy property to the Location class. It's intended to hold a value that describes how accurate the location estimation is (in meters).

Currently that value is based on the RMS of the multilateration, that may change though.

@hadiidbouk
Copy link

Thank you for your fast reply.

What are your plans about RMS? you will use another way?

@Steppschuh
Copy link
Contributor Author

It could also be based on the distance and amount of beacons that have been used for the multilateration. Probably related to #126.

marvinmirtschin
marvinmirtschin reviewed Oct 31, 2018
View reviewed changes
Copy link
Contributor

@marvinmirtschin marvinmirtschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refactor the singleton classes and change their static method with side effects to be non-static.

...oor Positioning/src/main/java/com/nexenio/bleindoorpositioning/ble/beacon/BeaconManager.java Outdated
@@ -36,13 +36,18 @@

private static final WindowFilter meanFilter = new MeanFilter(15, TimeUnit.SECONDS);


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicate empty line.

marvinmirtschin
marvinmirtschin requested changes Oct 31, 2018
View reviewed changes
app/src/main/java/com/nexenio/bleindoorpositioningdemo/ui/beaconview/map/BeaconMap.java
float advertisingRadius = (float) canvasProjection.getCanvasUnitsFromMeters(accuracy);
Paint historyFillPaint = new Paint(secondaryFillPaint);
PointF deviceCenter;
float heatmapRadius = (float) canvasProjection.getCanvasUnitsFromMeters(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the old implementation we wanted to use the accuracy instead of 1. Why did that change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the heatmap looked strange with that (I tried it). We use the circle around the device to visualize the accuracy.

@Steppschuh
Copy link
Contributor Author

We should refactor the singleton classes and change their static method with side effects to be non-static.

Agree. These are breaking changes though. We should start with deprecating these methods.

@Steppschuh Steppschuh added enhancement General improvement core lib Core Library sample app Sample App labels Oct 31, 2018
@Steppschuh Steppschuh self-assigned this Oct 31, 2018
@Steppschuh Steppschuh merged commit dd601fb into dev Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinmirtschin marvinmirtschin marvinmirtschin approved these changes

@Uwinator Uwinator Awaiting requested review from Uwinator

Assignees

@Steppschuh Steppschuh

Labels
core lib Core Library enhancement General improvement sample app Sample App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Steppschuh @codecov-io @hadiidbouk @marvinmirtschin