Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crypto-browserify #1219

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Dec 20, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #1218) and the maintainers have approved on my working plan.

Motivation

After the last update(3.0.0), wallet.requestSignIn functionality has been broken. The goal of this PR is to fix this problem by adding crypto-browserify package which is a port of node's crypto module to the browser.

Test Plan

Tested by running this project https://github.com/kujtimprenkuSQA/simple-naj-demo with the changes from this PR.

Related issues/PRs

#1218

@gtsonevv gtsonevv requested a review from vikinatora December 20, 2023 11:49
Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: 192431e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@near-js/crypto Minor
@near-js/accounts Patch
@near-js/biometric-ed25519 Patch
@near-js/keystores-browser Patch
@near-js/keystores-node Patch
@near-js/keystores Patch
near-api-js Patch
@near-js/signers Patch
@near-js/transactions Patch
@near-js/wallet-account Patch
@near-js/cookbook Patch
@near-js/providers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gtsonevv gtsonevv marked this pull request as draft December 20, 2023 11:54
@gtsonevv gtsonevv changed the title Add crypto-browserify Use noble-hashes to generate a random private key Dec 20, 2023
@gtsonevv gtsonevv changed the title Use noble-hashes to generate a random private key Add crypto-browserify Dec 20, 2023
@gtsonevv gtsonevv marked this pull request as ready for review December 20, 2023 14:02
@gtsonevv gtsonevv requested review from frol and gagdiez December 20, 2023 14:02
@vikinatora vikinatora merged commit 74a8783 into near:master Dec 20, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The wallet.requestSignIn stopped working on v3.0.0
3 participants