Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client interfaces for interacting with NEP standard contracts #1414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mpeterdev
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

These interfaces make it much simpler to begin interacting with Storage Management, Fungible Token, and Non-Fungible Token contracts by creating wrapped functionCall invocations which have proper type definitions for standardized function param and return types

Test Plan

For efficiency during this wind-down period for Pagoda, testing and cookbook creation were merged together. Cookbook examples for each interface also serve as a reasonable level of manual testing, and are run against near-sdk-rs example contracts deployed on testnet. See each cookbook file for reproduction steps

Related issues/PRs

NOTE

Much of the code in this change is intentionally repeated instead of being organized into reusable functions. The nature of this code is that it will likely be copy-pasted significantly by end users, and that is easier if logic is not abstracted away into helper functions

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 18aee6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@near-js/client Minor
@near-js/cookbook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mpeterdev mpeterdev force-pushed the feat/contract-standards branch 3 times, most recently from fe426cc to 35ce6c8 Compare October 22, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant