-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Performance tests for 'store' collections. #1195
[Testing] Performance tests for 'store' collections. #1195
Conversation
This works fine on other platforms, but fails the osx CI. Potential fixes:
|
I have fixed this by removing parallelism on account creation. However, it takes under a minute on linux builds and about 10 mins on mac os x. So it might still be interesting to investigate upgrading the runners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a test for random access iteration which was the main motivation for these tests in the first place.
near-sdk-macros/src/core_impl/info_extractor/trait_item_method_info.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vlad Frolov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is so much cleaner now! Great job
I will merge it now and will try to address near-workspaces-rs release sooner rather later. I hope it won't block publishing for near-sdk to crates.io
Thanks for great reviews! |
This covers basic operations for
store
collections as well as comparison betweenUnordered*
andIterable*
iteration performance.