Replace account id on rudderstack with hash id #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://near-wallet-pr-3089.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cj43kup8g3n78m4sd2rg. |
✅ Deploy Preview for unrivaled-zabaione-2fe19c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for glittering-pavlova-0e9247 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andy-haynes
reviewed
Aug 1, 2023
andy-haynes
requested changes
Aug 1, 2023
| @@ -88,3 +93,16 @@ export const resetUserState = () => { | |||
| } | |||
| return rudderanalytics.reset(); | |||
| }; | |||
|
|
|||
| export function accountIdToHash(accountId) { | |||
| if (!accountIdHash) { | |||
There was a problem hiding this comment.
Introducing state here now has introduced the potential for an event to be reported under the wrong accountId. Can we please compute the hash every time so as not to add any further complexity to event reporting?
andy-haynes
approved these changes
Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation to replace existing
account iddetails on RudderStack metrics with hash id.The team decided to not track account Id from RudderStack on Transfer Wizard. So similar to how it is implemented on
near-discoverywe hash the accountId and use it instead.This change need to be published to prod as soon as it passes the review.