generate_state_witness_parts cannot fail (#12645)

Does not return a `Result` from `generate_state_witness_parts()` as it cannot fail and some knock on removal of unnecessary `Result`s.
near · Jan 2, 2025 · 23e6b81 · 23e6b81
1 parent 69ae722
commit 23e6b81
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/chain/client/src/stateless_validation/partial_witness/partial_witness_actor.rs b/chain/client/src/stateless_validation/partial_witness/partial_witness_actor.rs
@@ -239,12 +239,11 @@ impl PartialWitnessActor {
             witness_bytes,
             &chunk_validators,
             &signer,
-        )?;
+        );
 
         if !contract_deploys.is_empty() {
             self.send_chunk_contract_deploys_parts(key, contract_deploys)?;
         }
-
         Ok(())
     }
 
@@ -256,7 +255,7 @@ impl PartialWitnessActor {
         witness_bytes: EncodedChunkStateWitness,
         chunk_validators: &[AccountId],
         signer: &ValidatorSigner,
-    ) -> Result<Vec<(AccountId, PartialEncodedStateWitness)>, Error> {
+    ) -> Vec<(AccountId, PartialEncodedStateWitness)> {
         tracing::debug!(
             target: "client",
             chunk_hash=?chunk_header.chunk_hash(),
@@ -268,7 +267,7 @@ impl PartialWitnessActor {
         let encoder = self.witness_encoders.entry(chunk_validators.len());
         let (parts, encoded_length) = encoder.encode(&witness_bytes);
 
-        Ok(chunk_validators
+        chunk_validators
             .iter()
             .zip_eq(parts)
             .enumerate()
@@ -285,7 +284,7 @@ impl PartialWitnessActor {
                 );
                 (chunk_validator.clone(), partial_witness)
             })
-            .collect_vec())
+            .collect_vec()
     }
 
     fn generate_contract_deploys_parts(
@@ -333,7 +332,7 @@ impl PartialWitnessActor {
         witness_bytes: EncodedChunkStateWitness,
         chunk_validators: &[AccountId],
         signer: &ValidatorSigner,
-    ) -> Result<(), Error> {
+    ) {
         // Capture these values first, as the sources are consumed before calling record_witness_sent.
         let chunk_hash = chunk_header.chunk_hash();
         let witness_size_in_bytes = witness_bytes.size_bytes();
@@ -349,7 +348,7 @@ impl PartialWitnessActor {
             witness_bytes,
             chunk_validators,
             signer,
-        )?;
+        );
         encode_timer.observe_duration();
 
         // Record the witness in order to match the incoming acks for measuring round-trip times.
@@ -364,7 +363,6 @@ impl PartialWitnessActor {
         self.network_adapter.send(PeerManagerMessageRequest::NetworkRequests(
             NetworkRequests::PartialEncodedStateWitness(validator_witness_tuple),
         ));
-        Ok(())
     }
 
     /// Sends the witness part to the chunk validators, except the chunk producer that generated the witness part.