Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove chunk header signature verification from epoch manager #12462

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Nov 14, 2024

The MR moves the chunk header signature verification outside of the epoch manager

@stedfn stedfn self-assigned this Nov 14, 2024
@stedfn stedfn changed the title . refactor: remove chunk header verification from epoch manager Nov 14, 2024
@stedfn stedfn changed the title refactor: remove chunk header verification from epoch manager refactor: remove chunk header signature verification from epoch manager Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.84%. Comparing base (7dfdfb0) to head (04b7807).

Files with missing lines Patch % Lines
chain/chain/src/signature_verification.rs 87.09% 1 Missing and 3 partials ⚠️
chain/chunks/src/shards_manager_actor.rs 80.00% 0 Missing and 3 partials ⚠️
chain/chain/src/validate.rs 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12462       +/-   ##
===========================================
+ Coverage    1.60%   69.84%   +68.24%     
===========================================
  Files         667      839      +172     
  Lines      118468   169381    +50913     
  Branches   118468   169381    +50913     
===========================================
+ Hits         1897   118310   +116413     
+ Misses     116363    45821    -70542     
- Partials      208     5250     +5042     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (ø)
db-migration 0.16% <0.00%> (ø)
genesis-check 1.29% <0.00%> (+<0.01%) ⬆️
linux 69.16% <85.45%> (+67.55%) ⬆️
linux-nightly 69.43% <85.45%> (?)
macos 51.01% <78.18%> (?)
pytests 1.60% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.40% <0.00%> (+<0.01%) ⬆️
unittests 69.67% <85.45%> (?)
upgradability 0.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@stedfn stedfn requested a review from pugachAG November 14, 2024 23:36
@stedfn stedfn marked this pull request as ready for review November 14, 2024 23:37
@stedfn stedfn requested a review from a team as a code owner November 14, 2024 23:37
Copy link
Contributor

@shreyan-gupta shreyan-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we would be moving other verify functions to this file soon?

chain/chain/src/signature_verification.rs Show resolved Hide resolved
@stedfn
Copy link
Contributor Author

stedfn commented Nov 15, 2024

I'm assuming we would be moving other verify functions to this file soon?

Yes, that's what I plan

@stedfn stedfn added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@stedfn stedfn added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@stedfn stedfn added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@stedfn stedfn added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants