-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove chunk header signature verification from epoch manager #12462
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12462 +/- ##
===========================================
+ Coverage 1.60% 69.84% +68.24%
===========================================
Files 667 839 +172
Lines 118468 169381 +50913
Branches 118468 169381 +50913
===========================================
+ Hits 1897 118310 +116413
+ Misses 116363 45821 -70542
- Partials 208 5250 +5042
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we would be moving other verify functions to this file soon?
Yes, that's what I plan |
This reverts commit a334724.
The MR moves the chunk header signature verification outside of the epoch manager